Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra type parameters #2580

Merged
merged 2 commits into from
Jan 25, 2025
Merged

remove extra type parameters #2580

merged 2 commits into from
Jan 25, 2025

Conversation

prbzrg
Copy link
Member

@prbzrg prbzrg commented Jan 24, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #2579

@prbzrg prbzrg marked this pull request as ready for review January 24, 2025 14:51
@prbzrg prbzrg marked this pull request as draft January 24, 2025 15:21
@prbzrg prbzrg marked this pull request as ready for review January 24, 2025 15:22
@prbzrg
Copy link
Member Author

prbzrg commented Jan 24, 2025

Fails seem unrelated, but I wait for CI run to be completed and will check them.

@prbzrg
Copy link
Member Author

prbzrg commented Jan 24, 2025

I checked the CI, all errors seem unrelated.

@ChrisRackauckas
Copy link
Member

Yes those CI things are unrelated. This is a bit better than the hotfix, but can you address the comment? Then I think we can merge it. But I just wanted to get a hotfix out ASAP the moment I saw this. Sorry I was on an international flight without wifi.

@ChrisRackauckas ChrisRackauckas merged commit 2046615 into SciML:master Jan 25, 2025
111 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] broke the precompilation
3 participants