Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia 1.6 (again) #48

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Support Julia 1.6 (again) #48

merged 2 commits into from
Apr 25, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Apr 22, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This PR makes EnzymeCoreExt and ChainRulesExt unconditional dependencies for Julia <1.9, thus allowing support for older Julia versions.
We initially decided against it in #40 (comment), but as shown by #47 some users would like this feature. It is zero-cost for us, so why not?

@gdalle gdalle linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aa2429e) to head (fa3733a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           64        64           
=========================================
  Hits            64        64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 22, 2024

@ChrisRackauckas @Vaibhavdixit02 I think this doesn't hurt, right?

@gdalle gdalle changed the title Support Julia 1.6 Support Julia 1.6 (again) Apr 22, 2024
@gdalle
Copy link
Collaborator Author

gdalle commented Apr 25, 2024

Bump @Vaibhavdixit02

@Vaibhavdixit02 Vaibhavdixit02 merged commit 5d250d1 into main Apr 25, 2024
5 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the gd/julia16 branch April 25, 2024 12:46
@ChrisRackauckas
Copy link
Member

If you all want to maintain it, go for it. We don't plan to put any effort into the old LTS since the new one is already out.

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 26, 2024

I didnt have that in mind, so all of SciML is basically willing to drop 1.6?

@ChrisRackauckas
Copy link
Member

Yes.

@gdalle gdalle mentioned this pull request May 2, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support older Julia versions?
3 participants