Removed bug and updated assertion

[vijay8451]

• Removed fix bug.
• Updated assert to avoid false fail.
• test result:

$ py.test tests/foreman/ui/test_repository.py -k test_positive_recommended_repos

collected 21 items / 20 deselected / 1 selected                                                                                                                             

tests/foreman/ui/test_repository.py .                                                                                                                                 [100%]

================================================================= 1 passed, 20 deselected in 177.06 seconds =================================================================

[codecov]

Codecov Report

Merging #7589 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7589      +/-   ##
==========================================
+ Coverage   67.62%   67.63%   +0.01%     
==========================================
  Files          30       30              
  Lines        3734     3736       +2     
==========================================
+ Hits         2525     2527       +2     
  Misses       1209     1209

Impacted Files	Coverage Δ
robottelo/constants.py	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ba3cf...3afaeb6. Read the comment docs.

[mirekdlugosz]

Looks innocent enough, but can you also explain why is it necessary to change assertion from "Fast Datapath for RHEL 8" to "Red Hat Ansible Engine"? Should we remove "fdrh8" from constants as well?

[vijay8451]

Looks innocent enough, but can you also explain why is it necessary to change assertion from "Fast Datapath for RHEL 8" to "Red Hat Ansible Engine"?

Yeah, because as checked with current manifest the Red Hat Ansible Engine repo shows on first page of 'Red Hat Repositories' instead of Fast Datapath for RHEL 8 hence updated it

Should we remove "fdrh8" from constants as well?

yeah, it's removed now.

[swadeley]

ACK

[mirekdlugosz]

Yeah, because as checked with current manifest the Red Hat Ansible Engine repo shows on first page of 'Red Hat Repositories' instead of Fast Datapath for RHEL 8 hence updated it

So the real problem is that session.redhatrepository.read(recommended_repo='off') is unable to read more than one page?

If that's the case, please file issue in Airgun.

[vijay8451]

So the real problem is that session.redhatrepository.read(recommended_repo='off') is unable to read more than one page?
If that's the case, please file issue in Airgun.

We could add ... but I do not see much value add except to see the repos in a list ...
I have opened the issue for same: SatelliteQE/airgun#440