Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.17.z] less flakiness in rex module #17663

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[6.17.z] less flakiness in rex module #17663

merged 1 commit into from
Feb 25, 2025
+5 −20

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17519

Problem Statement

Trying to make a couple of problematic tests behave more predictably.

Solution

Asserting for rex status instead of result, removing some time assertions

Related Issues

@Satellite-QE Satellite-QE requested a review from a team as a code owner February 24, 2025 11:24
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 24, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k test_positive_run_scheduled_job_template

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 24, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 10280
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k test_positive_run_scheduled_job_template --external-logging
Test Result : ========== 1 passed, 71 deselected, 84 warnings in 804.47s (0:13:24) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 24, 2025
@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-6.17.z-4bd56d0891d02387cfaccdeef5390f9a88173026 branch from 3409620 to eb6b119 Compare February 25, 2025 09:51
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) February 25, 2025 09:53
@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k test_positive_run_scheduled_job_template

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 10306
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k test_positive_run_scheduled_job_template --external-logging
Test Result : ========== 1 passed, 71 deselected, 84 warnings in 1077.34s (0:17:57) ==========

@pondrejk
Copy link
Contributor

eh, I don't know what is needed for this to allow merge

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 25, 2025
@Satellite-QE Satellite-QE merged commit 930cba2 into 6.17.z Feb 25, 2025
12 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.17.z-4bd56d0891d02387cfaccdeef5390f9a88173026 branch February 25, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pondrejk pondrejk

Labels
6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @pondrejk