Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.17.z] Fix typo in capsule_setup helper #17658

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17657

Problem Statement

Recent change in PR #17489 updated capsule_setup helper, which now fails with below error

failed on setup with "dynaconf.vendor.box.exceptions.BoxKeyError: "'DynaBox' object has no attribute 'rhelsource'". Did you mean: 'rhel_source'?"

Solution

Fix typo in capsule_setup helper

Related Issues

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit ab40a81)
@Satellite-QE Satellite-QE requested a review from a team as a code owner February 24, 2025 09:36
@Satellite-QE Satellite-QE added 6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 24, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_puppetplugin.py::test_positive_enable_disable_logic

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 24, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 10273
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_puppetplugin.py::test_positive_enable_disable_logic --external-logging
Test Result : ================= 1 failed, 17 warnings in 1966.96s (0:32:46) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 24, 2025
@Gauravtalreja1
Copy link
Collaborator

PRT failure look unrelated to the changes in PR, instead it looks like a bug in Puppet removal

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch fixes what it is supposed to fix. As Gaurav pointed out, the PRT failure hints at some other issue.

@ogajduse ogajduse enabled auto-merge (squash) February 24, 2025 11:39
@ogajduse ogajduse merged commit db4eaaa into 6.17.z Feb 24, 2025
9 checks passed
@ogajduse ogajduse deleted the cherry-pick-6.17.z-ab40a81542aca984cf42efc89c9dca17b981f67a branch February 24, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants