Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configure_kea_dhcp6_server fixture for IPv4 #17656

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix configure_kea_dhcp6_server fixture for IPv4 #17656

merged 1 commit into from
Feb 24, 2025

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

When setup configure_kea_dhcp6_server fixture is run for IPv4, it fails with "failed on setup with "ValueError: configure_kea_dhcp6_server did not yield a value"

Solution

Fix configure_kea_dhcp6_server fixture for IPv4 by yielding None value since this fixture intended for IPv6 only

Related Issues

@Gauravtalreja1 Gauravtalreja1 added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.17.z labels Feb 24, 2025
@Gauravtalreja1 Gauravtalreja1 self-assigned this Feb 24, 2025
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner February 24, 2025 07:10
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning
provisioning: true
env:
     BROKER_SSH__BACKEND: hussh

@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label Feb 24, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10270
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_provisioning.py::test_rhel_pxe_provisioning --external-logging --include-onprem-provisioning
Test Result : =========== 7 failed, 1 passed, 1572 warnings in 9462.89s (2:37:42) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 24, 2025
@Gauravtalreja1
Copy link
Collaborator Author

PRT failures look unrelated to the changes in the fixture

@Gauravtalreja1 Gauravtalreja1 requested a review from a team February 24, 2025 10:06
shweta83
shweta83 approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shweta83 shweta83 merged commit b1ed2ac into SatelliteQE:master Feb 24, 2025
14 of 15 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
@Gauravtalreja1 @web-flow
Fix configure_kea_dhcp6_server fixture for IPv4 (#17656)
7bd5403 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit b1ed2ac)
@Satellite-QE Satellite-QE mentioned this pull request Feb 24, 2025
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the fix-kea-fixture-ipv4 branch February 24, 2025 10:13
shweta83 pushed a commit that referenced this pull request Feb 24, 2025
@Satellite-QE @Gauravtalreja1
[6.17.z] Fix configure_kea_dhcp6_server fixture for IPv4 (#17662)
5c1b2db 
Fix configure_kea_dhcp6_server fixture for IPv4 (#17656)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit b1ed2ac)

Co-authored-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@shweta83 shweta83 shweta83 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.17.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Failed Indicates that latest PRT run is failed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @pondrejk @shweta83