update assertion for discovery plugin test as per IPv4/Ipv6 ip address

[amolpati30]

Previously, there was only one column for IP Address. However, starting from version 6.17, both IPv4 and IPv6 networks are used. When a discovery host is created, two separate columns are displayed for IPv4 and IPv6. To prevent assertion failures, the IP address will be fetched based on the respective network.

Prior -

Latest -

[shweta83]

We can assert the values based on server.is_ipv6 but this won't work when we will have dual stack network so I would suggest to assert both without if else.

[amolpati30]

When a dual-stack network is available, we can take the appropriate action accordingly.
When creating a discovery host, there are two columns for IPv4 and IPv6. The values are fetched from these columns and matched with ip_address = gen_ipaddr(). I believe we need to update this section ip_address = gen_ipaddr() to ensure the assertion works with dual-stack later.

[shweta83]

I understand that but you would still need to check which address to read (ipv4 or ipv6) from UI instead of values['table'][0]['IP Address'].
gen_ipaddr() already takes care of which ip address to pick.

[amolpati30]

Do you have an example for reference?

[Gauravtalreja1]

Did you try assert values['table'][0]['IPv6' if settings.server.is_ipv6 else 'IPv4'] == ip_address ?

[shweta83]

@amolpati30 I don't think there is any reference in robottelo currently but you can check based on is_ipv6.

[amolpati30]

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveryrule.py -k test_positive_list_host_based_on_rule_search_query

[Satellite-QE]

PRT Result

Build Number: 10256
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_discoveryrule.py -k test_positive_list_host_based_on_rule_search_query --external-logging
Test Result : =========== 1 passed, 3 deselected, 17 warnings in 663.49s (0:11:03) ===========

[Gauravtalreja1]

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveryrule.py -k test_positive_list_host_based_on_rule_search_query
network_type: ipv6

[Satellite-QE]

PRT Result

Build Number: 10257
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveryrule.py -k test_positive_list_host_based_on_rule_search_query --external-logging
Test Result : ====== 1 failed, 3 deselected, 15 warnings, 1 error in 621.48s (0:10:21) =======