add test_name to the capabilities for remote browser
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rplevka
force-pushed
the
remote_testname
branch
2 times, most recently
from
95dc146 to
dcd3e71
Compare
|
This change makes it easier to work with Zalenium, correct? Does it have any impact on tests run on SauceLabs? Namely, I wonder if it fixes #348 |
|
yeah it turns the random uuids into ..not sure about saucelabs tho, as far as i know saucelabs already receive the test name in the capabilities and show them on the dashboard. |
|
ok, so I set up local saucelabs config and ran the test and it looks like the test name is properly resolved even before the actual session starts (on saucelabs): without my commit applied: ..so yep, apparently I'm fixing more issues than I originally intended ;) |
vijay8451
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remote_browserdid not forward theself.test_nameas one of the desired_capabilities, leaving the session without a name (causing random uuid to be generated for them and causing chaos in the Dashboard). This fixes it.