Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the locator for create image #365

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Updated the locator for create image #365

merged 1 commit into from
Jul 19, 2019

Conversation

vijay8451
Copy link
Member

  • Updated the locator for create image
  • Test result:
tests/foreman/ui/test_computeresource.py::test_positive_image_end_to_end PASSED                                                                                  [ 50%]
tests/foreman/ui/test_computeresource_vmware.py::test_positive_image_end_to_end PASSED                                                                           [100%]

@vijay8451 vijay8451 self-assigned this Jul 16, 2019
@vijay8451 vijay8451 mentioned this pull request Jul 16, 2019
Closed
mirekdlugosz
mirekdlugosz approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@mirekdlugosz mirekdlugosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad this locator changed. id looked like unique and more stable thing to use. Would be good idea to ask devs to add id back, or create PR for that ourselves.
Of course this one is +1.

@vijay8451
Copy link
Member Author

vijay8451 commented Jul 18, 2019 •
edited
Loading

Too bad this locator changed. id looked like unique and more stable thing to use. Would be good idea to ask devs to add id back, or create PR for that ourselves.
Of course this one is +1.

As discussed , you are going to send the upstream PR around it ... thanks

@vijay8451 vijay8451 mentioned this pull request Jul 19, 2019
Open
@vijay8451
Copy link
Member Author

Follow-up opened #369

omkarkhatavkar
omkarkhatavkar approved these changes Jul 19, 2019
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@omkarkhatavkar omkarkhatavkar merged commit 7b1cacd into SatelliteQE:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

@mirekdlugosz mirekdlugosz mirekdlugosz approved these changes

@latran latran Awaiting requested review from latran

@lhellebr lhellebr Awaiting requested review from lhellebr

Assignees

@vijay8451 vijay8451

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijay8451 @omkarkhatavkar @mirekdlugosz