Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve host entity #327

Merged
merged 2 commits into from
May 28, 2019
Merged

Improve host entity #327

merged 2 commits into from
May 28, 2019

Conversation

oshtaier
Copy link
Contributor

No description provided.

ldjebran
ldjebran reviewed May 27, 2019
View reviewed changes
ldjebran
ldjebran reviewed May 27, 2019
View reviewed changes
ldjebran
ldjebran previously approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, remain 2 comments.

vijay8451
vijay8451 reviewed May 28, 2019
View reviewed changes
airgun/views/computeresource.py
storage_pool = FilteredDropdown(id="pool_name")
size = TextInput(locator=".//input[contains(@id, 'capacity')]")
storage_type = FilteredDropdown(id="format_type")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we include the Allocation (GB) too ..
what do you think ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijay8451 Let's me move that out of the scope of that PR as it is probably require separate widget for it:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshtaier yeah it looks more a new widget but I have seen same used by multiple Compute resource hence worth to have that.
as new issue #330 opened , I am fine with it :)

airgun/views/host.py
storage_pool = FilteredDropdown(id="pool_name")
size = TextInput(locator=".//input[contains(@id, 'capacity')]")
storage_type = FilteredDropdown(id="format_type")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@oshtaier
Copy link
Contributor Author

Created issue for that:
#330

vijay8451
vijay8451 approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@vijay8451 vijay8451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks a great improvement .. ACK

ldjebran
ldjebran approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ldjebran ldjebran merged commit 4ae2325 into SatelliteQE:master May 28, 2019
@lhellebr
Copy link
Contributor

@oshtaier I believe this PR has broken create_fake_host:
E ValueError: Could not find a corresponding registered view. where the view is supposed to be provider_content.

@lhellebr lhellebr mentioned this pull request Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldjebran ldjebran ldjebran approved these changes

@vijay8451 vijay8451 vijay8451 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshtaier @lhellebr @ldjebran @vijay8451