-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix podman on Github Actions #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to merge when pipeline is green
a8ade91
to
9a1db61
Compare
52b306a
to
efeb73e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 78.83% 79.61% +0.78%
==========================================
Files 21 21
Lines 1658 1628 -30
==========================================
- Hits 1307 1296 -11
+ Misses 351 332 -19 ☔ View full report in Codecov by Sentry. |
9265d85
to
469133e
Compare
requirements.txt
Outdated
msrest==0.7.1 | ||
openqa-client==4.2.3 | ||
protobuf==5.28.2 | ||
python-dateutil==2.9.0.post0 | ||
requests==2.32.3 | ||
texttable==1.7.0 | ||
urllib3==2.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes will certainly require a proper testing of ALL functionality ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
urllib3 is a library that is pulled by all the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I get this , but nevertheless it is core functionality which had certain version now it will have some other version . Maybe higher , maybe lower which may cause regression in any unexpected place . Once again I am NOT saying that you did something wrong I am just saying that you touched core element hence this will require proper testing
28ed80c
to
d3f1ecc
Compare
d3f1ecc
to
7dfb385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR: