Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman on Github Actions #424

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented Jan 27, 2025

This PR:

  • Enables the podman socket
  • Updates the podman version

asmorodskyi
asmorodskyi previously approved these changes Jan 27, 2025
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge when pipeline is green

@ricardobranco777 ricardobranco777 changed the title Update test requirements.txt Update requirements Jan 27, 2025
@ricardobranco777 ricardobranco777 force-pushed the test_req branch 4 times, most recently from 52b306a to efeb73e Compare January 27, 2025 17:06
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (b2ab094) to head (7dfb385).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   78.83%   79.61%   +0.78%     
==========================================
  Files          21       21              
  Lines        1658     1628      -30     
==========================================
- Hits         1307     1296      -11     
+ Misses        351      332      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardobranco777 ricardobranco777 force-pushed the test_req branch 4 times, most recently from 9265d85 to 469133e Compare January 27, 2025 18:13
requirements.txt Outdated
msrest==0.7.1
openqa-client==4.2.3
protobuf==5.28.2
python-dateutil==2.9.0.post0
requests==2.32.3
texttable==1.7.0
urllib3==2.2.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes will certainly require a proper testing of ALL functionality ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urllib3 is a library that is pulled by all the others.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I get this , but nevertheless it is core functionality which had certain version now it will have some other version . Maybe higher , maybe lower which may cause regression in any unexpected place . Once again I am NOT saying that you did something wrong I am just saying that you touched core element hence this will require proper testing

@ricardobranco777 ricardobranco777 added the wip Work in progress label Jan 27, 2025
@ricardobranco777 ricardobranco777 force-pushed the test_req branch 3 times, most recently from 28ed80c to d3f1ecc Compare January 27, 2025 20:09
@ricardobranco777 ricardobranco777 changed the title Update requirements Fix podman on Github Actions Jan 27, 2025
Copy link
Collaborator

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardobranco777 ricardobranco777 merged commit f6e31a6 into SUSE:master Jan 27, 2025
15 checks passed
@ricardobranco777 ricardobranco777 deleted the test_req branch January 27, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants