Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logic to check for pcw_ignore flag #423

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

linguini-dev
Copy link
Contributor

@linguini-dev linguini-dev commented Jan 27, 2025

This PR adds logic that allows us to prevent PCW from deleting disks in Google Cloud if the flag pcw_ignore is configured.

Related ticket: https://progress.opensuse.org/issues/174220

Test run logs:

2025-01-29 17:26:16,560 ocw.lib.gce  DEBUG    [namespace] Searching for disks in europe-west1-b
2025-01-29 17:26:16,725 ocw.lib.gce  DEBUG    [namespace] 1 disks found
2025-01-29 17:26:16,789 ocw.lib.gce  DEBUG    [namespace] Ignoring testing-pcw-ignore due to 'pcw_ignore' label set to '1'

@ricardobranco777 ricardobranco777 marked this pull request as ready for review January 29, 2025 17:32
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.60%. Comparing base (7dfb385) to head (d871823).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
ocw/lib/gce.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   79.61%   79.60%   -0.01%     
==========================================
  Files          21       21              
  Lines        1628     1632       +4     
==========================================
+ Hits         1296     1299       +3     
- Misses        332      333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmorodskyi asmorodskyi merged commit fd0627f into SUSE:master Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants