Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update angular sample for stackblitz compatibility #40

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Jul 3, 2024

Description

Fixes the StackBlitz workspace for the Angular sample by removing the zone.js polyfill. You can view the working StackBlitz for this branch here.

Changes Made

  • Upgraded Angular to version 18 to eliminate the dependency on zone.js. For more details, refer to the Angular v18 release notes.

@jboix jboix requested a review from amtins July 3, 2024 08:41
@jboix jboix self-assigned this Jul 3, 2024
@jboix jboix changed the title fix: update Angular sample for stackblitz compatibility fix: update angular sample for stackblitz compatibility Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-03 09:57 UTC

@jboix jboix force-pushed the fix/angular-sample branch from da1eb9c to 363cf12 Compare July 3, 2024 08:42
Upgraded Angular to version 18 in order to remove zone.js due to improper polyfilling issues in the
StackBlitz workspace.
@jboix jboix force-pushed the fix/angular-sample branch from 363cf12 to fc0d65a Compare July 3, 2024 09:48
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 4e7b842 Jul 3, 2024
2 checks passed
@jboix jboix deleted the fix/angular-sample branch July 3, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants