-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest bones sources #577
base: main
Are you sure you want to change the base?
Ingest bones sources #577
Conversation
script is now running but just change logic so if source does not exist then ingest
Kelle's changes
…IMPLE-db into ingestBonesSources
If you run the script with |
Tests aren't passing because of changes made to |
I've run the script and saved the JSON files and we have two problems:
Both of these are tricky and I will think on them. |
ingest_publication( | ||
db, | ||
bibcode = ads, | ||
reference=adsRef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference=adsRef |
This is the line which is giving the inconsistent formatting for the references.
ingest_source( | ||
db, | ||
"LHS 292", | ||
search_db=False, | ||
reference="Roja12", | ||
ra_col_name="ra", | ||
dec_col_name="deg", | ||
epoch_col_name="epoch", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've ingested LHS 292 directly and opened an issue with the bug in ingest_sources. astrodbtoolkit/astrodb_utils#110
Ok, I fixed the minus sign problem and got around the LHS 292/2924 confusion but I found a new and BIG bug. The CSV file we're reading from got messed up somehow. The discovery references are linked to the wrong sources. Here are three rows from the CSV file y'all made:
and those three rows from the Bones Archive
Please work on making a correct CSV file and re-running the updated script. |
Short description: ingest sources in photometry from the BONES archive
Link to relevant issue: Closes #544 (sources only)
For data ingests: