Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest bones sources #577

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

kaseyLee123
Copy link

@kaseyLee123 kaseyLee123 commented Feb 8, 2025

Short description: ingest sources in photometry from the BONES archive

Link to relevant issue: Closes #544 (sources only)

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@kelle
Copy link
Collaborator

kelle commented Feb 14, 2025

If you run the script with DB_Save = True, how many JSON files get modified?

@kelle
Copy link
Collaborator

kelle commented Feb 14, 2025

Tests aren't passing because of changes made to astrodb_utils. I'll work on that.

@kelle
Copy link
Collaborator

kelle commented Feb 14, 2025

I've run the script and saved the JSON files and we have two problems:

  1. its not recognizing the unicode minus sign as a minus sign and is adding it as an other name.
    { "other_name": "WISEA J000430.66-260402.3" }, { "other_name": "WISEA J000430.66\u2212260402.3" }
  2. Also, I noticed it confused LHS 292 with LHS 2924.

Both of these are tricky and I will think on them.

ingest_publication(
db,
bibcode = ads,
reference=adsRef
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reference=adsRef

This is the line which is giving the inconsistent formatting for the references.

Comment on lines 35 to 43
ingest_source(
db,
"LHS 292",
search_db=False,
reference="Roja12",
ra_col_name="ra",
dec_col_name="deg",
epoch_col_name="epoch",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ingested LHS 292 directly and opened an issue with the bug in ingest_sources. astrodbtoolkit/astrodb_utils#110

@kelle
Copy link
Collaborator

kelle commented Feb 14, 2025

Ok, I fixed the minus sign problem and got around the LHS 292/2924 confusion but I found a new and BIG bug. The CSV file we're reading from got messed up somehow. The discovery references are linked to the wrong sources.

Here are three rows from the CSV file y'all made:

LHS 2090,135.0981088,21.83469481,sdM7,Lodieu et al. 2017,13.192,13.022,0.014,0.016,17.051,18.826,15.793,0.003,0.016,0.005,,,,,,,,,,,,,,,,,14.065,13.575,13.396,0.030,0.033,0.034,,,16.307,15.616,15.319,,,0.003,0.006,0.000,,,,,,,,,,,,
LP 426-61,137.2654234,19.69564333,sdT4.5,Burningham et al. 2010,18.059,17.096,0.130,0.182,,,,,,,,,,,,,19.950,18.464,,18.793,,0.145,0.064,,0.122,,,,,,,,,,21.483,21.060,20.250,,,0.047,0.109,0.174,,,,,,,,,,,,
ULAS J092605.47+083516.9,141.522819,8.588039,sdM8.5,Lodieu et al. 2017,16.859,16.866,0.047,0.144,20.892,21.238,19.597,0.015,0.178,0.073,,,,,,,18.156,17.645,,17.487,17.208,0.030,0.029,,0.075,0.077,,,,,,,,21.531,20.090,19.246,18.870,,0.040,0.014,0.026,0.029,,,,,,,,,,,,

and those three rows from the Bones Archive

LHS 2090	133.9529947	36.6004475	sdM7	Rojas-Ayala et al. 2012													
LP 426-61	135.0981088	21.8346948	sdM7	Lodieu et al. 2017	3088.000		-0.100	Marfil et al. 2021									
ULAS J092605.47+083516.9	137.2654234	19.6956433	sdT4.5	Burningham et al. 2010													

Please work on making a correct CSV file and re-running the updated script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest the BONES Archive of low metallicity sources
2 participants