Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAIA DR3 radial velocities ingest #253

Closed
wants to merge 19 commits into from
Closed

GAIA DR3 radial velocities ingest #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cd894c2
Starting the GAIA DR3 data ingest for radial velocites
SherelynA Jun 13, 2022
44735bd
created a function for the radial velocity ingest
SherelynA Jun 13, 2022
f31ada2
new changes
SherelynA Jun 13, 2022
677d207
new changes
SherelynA Jun 13, 2022
cf2a8a6
Got the query to wokr
SherelynA Jun 14, 2022
5446353
Ingested 22 radial velocities
SherelynA Jun 14, 2022
6f66805
added comments
SherelynA Jun 14, 2022
01208a7
updated ingest with save_db
SherelynA Jun 16, 2022
44a42a9
JSON files for gaiadr3 ingest
SherelynA Jun 16, 2022
f0ec117
changes value for unusued references
SherelynA Jun 21, 2022
24bf584
Update scripts/ingests/ingest_utils.py
SherelynA Jun 24, 2022
022142e
Added Tests for RVs
SherelynA Jun 24, 2022
7d49fbe
Not necessary to ingest the publication again
SherelynA Jun 24, 2022
eec09a6
Fixed spelling
SherelynA Jun 24, 2022
104f5ce
Changed query in rv test
SherelynA Jun 24, 2022
b2eee82
edited assert string
SherelynA Jun 24, 2022
6dd68d2
made fake data for testing ingest rv function
SherelynA Jun 24, 2022
166a07f
test for ingest rv function
SherelynA Jun 26, 2022
208525c
added suggestion for unicode
SherelynA Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions data/2mass_j01225093-2439505.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,14 @@
"comments": null,
"reference": "Zach13"
}
],
"RadialVelocities": [
{
"radial_velocity": 10.68130111694336,
"radial_velocity_error": 2.940765857696533,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j02192210-3925225.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,5 +152,14 @@
"comments": null,
"reference": "Gira11"
}
],
"RadialVelocities": [
{
"radial_velocity": 11.962318420410156,
"radial_velocity_error": 1.9461727142333984,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j03111547+0106307.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "GaiaEDR3"
}
],
"RadialVelocities": [
{
"radial_velocity": 23.23390007019043,
"radial_velocity_error": 5.15696907043457,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j06500102-6014569.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,5 +143,14 @@
"comments": null,
"reference": "GaiaEDR3"
}
],
"RadialVelocities": [
{
"radial_velocity": 26.18565559387207,
"radial_velocity_error": 0.15839439630508423,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j08034469+0827000.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "GaiaEDR3"
}
],
"RadialVelocities": [
{
"radial_velocity": -3.650470018386841,
"radial_velocity_error": 3.5198264122009277,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j10172689-5354265.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "Teix09"
}
],
"RadialVelocities": [
{
"radial_velocity": 15.821921348571777,
"radial_velocity_error": 0.7277317643165588,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j10585054-2346206.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "Gira11"
}
],
"RadialVelocities": [
{
"radial_velocity": 11.02063274383545,
"radial_velocity_error": 37.235923767089844,
Comment on lines +152 to +153
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to ingest RVs that have a very large uncertainty? @Will-Cooper , thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bigger discussion @kelle; I wouldn't trust any RVs for UCDs from Gaia to do any science but is the idea of the database to record all forms of data or just what we are saying is trustworthy? I see the Gaia G mag is 13.7 and the limit for RV processing is 14, so it's borderline snuck in there at the most uncertain bound.

"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
4 changes: 2 additions & 2 deletions data/2mass_j11074656-7615174.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"epoch": 2000.0,
"equinox": "J2000",
"shortname": null,
"reference": "Góme01",
"reference": "G\u00f3me01",
"other_references": null,
"comments": null
}
Expand All @@ -34,4 +34,4 @@
"other_references": null
}
]
}
}
6 changes: 3 additions & 3 deletions data/2mass_j11085497–7632410.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Sources": [
{
"source": "2MASS J11085497–7632410",
"source": "2MASS J11085497\u20137632410",
"ra": 167.229,
"dec": -76.5448,
"epoch": 2000.0,
Expand All @@ -14,7 +14,7 @@
],
"Names": [
{
"other_name": "2MASS J11085497–7632410"
"other_name": "2MASS J11085497\u20137632410"
}
],
"Spectra": [
Expand All @@ -34,4 +34,4 @@
"other_references": null
}
]
}
}
9 changes: 9 additions & 0 deletions data/2mass_j11112820-2655027.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "Qi__15"
}
],
"RadialVelocities": [
{
"radial_velocity": 7.885170936584473,
"radial_velocity_error": 2.8705954551696777,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
8 changes: 4 additions & 4 deletions data/2mass_j11123099–7653342.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"Sources": [
{
"source": "2MASS J11123099–7653342",
"source": "2MASS J11123099\u20137653342",
"ra": 168.129,
"dec": -76.8928,
"epoch": 2000.0,
"equinox": "J2000",
"shortname": null,
"reference": "Lópe04",
"reference": "L\u00f3pe04",
"other_references": null,
"comments": null
}
],
"Names": [
{
"other_name": "2MASS J11123099–7653342"
"other_name": "2MASS J11123099\u20137653342"
}
],
"Spectra": [
Expand All @@ -34,4 +34,4 @@
"other_references": null
}
]
}
}
9 changes: 9 additions & 0 deletions data/2mass_j12175920-3734433.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "Gira11"
}
],
"RadialVelocities": [
{
"radial_velocity": 13.720625877380371,
"radial_velocity_error": 2.4011337757110596,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
6 changes: 3 additions & 3 deletions data/2mass_j15591135–2338002.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Sources": [
{
"source": "2MASS J15591135–2338002",
"source": "2MASS J15591135\u20132338002",
"ra": 239.797,
"dec": -23.6334,
"epoch": 2000.0,
Expand All @@ -14,7 +14,7 @@
],
"Names": [
{
"other_name": "2MASS J15591135–2338002"
"other_name": "2MASS J15591135\u20132338002"
}
],
"Spectra": [
Expand All @@ -34,4 +34,4 @@
"other_references": null
}
]
}
}
6 changes: 3 additions & 3 deletions data/2mass_j16060391–2056443.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Sources": [
{
"source": "2MASS J16060391–2056443",
"source": "2MASS J16060391\u20132056443",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unicode.

"ra": 241.516,
"dec": -20.9457,
"epoch": 2000.0,
Expand All @@ -14,7 +14,7 @@
],
"Names": [
{
"other_name": "2MASS J16060391–2056443"
"other_name": "2MASS J16060391\u20132056443"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more unicode. \u2013 instead of -

}
],
"Spectra": [
Expand All @@ -34,4 +34,4 @@
"other_references": null
}
]
}
}
9 changes: 9 additions & 0 deletions data/2mass_j19303829-1335083.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,14 @@
"comments": null,
"reference": "Shko12"
}
],
"RadialVelocities": [
{
"radial_velocity": -17.518739700317383,
"radial_velocity_error": 4.032501220703125,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/2mass_j20530910-0133039.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,5 +135,14 @@
"comments": null,
"reference": "Shko12"
}
],
"RadialVelocities": [
{
"radial_velocity": -42.880367279052734,
"radial_velocity_error": 1.8472751379013062,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
12 changes: 9 additions & 3 deletions data/Publications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6852,13 +6852,13 @@
"description": "ISOCAM observations of the Chamaeleon I dark cloud"
},
{
"publication": "Lópe04",
"publication": "L\u00f3pe04",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got some unicode in here and I'm not sure what to do. @dr-rodriguez , thoughts? I feel like we've dealt with this before but I don't remember the discussion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now, but we will need to merge the latest changes from main into this branch and re-ingest the RVs

"bibcode": "2004A&A...416..555L",
"doi": "10.1051/0004-6361:20031720",
"description": "The brown dwarf population in the Chamaeleon I cloud"
},
{
"publication": "Góme01",
"publication": "G\u00f3me01",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more unicode. Not sure if we want \u00f3 or ó. @dr-rodriguez ?

"bibcode": "2001AJ....121..974G",
"doi": "10.1086/318776",
"description": "A Near-Infrared Imaging Survey of the Chamaeleon I Dark Cloud"
Expand All @@ -6874,5 +6874,11 @@
"bibcode": "2020MNRAS.491.5925M",
"doi": "10.1093/mnras/stz3441",
"description": "Spectral library of age-benchmark low-mass stars and brown dwmarfs"
},
{
"publication": "GaiaDR3",
"bibcode": null,
"doi": "10.1051/0004-6361/202243940",
"description": "Gaia Data Release 3.Summary of the content and survey properties"
}
]
]
9 changes: 9 additions & 0 deletions data/g_44-9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,14 @@
"comments": null,
"reference": "Shko12"
}
],
"RadialVelocities": [
{
"radial_velocity": 10.951985359191895,
"radial_velocity_error": 3.736882209777832,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/gj_1245b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,14 @@
"comments": null,
"reference": "Harr93"
}
],
"RadialVelocities": [
{
"radial_velocity": 3.9324750900268555,
"radial_velocity_error": 0.3760128319263458,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/lhs_197.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,14 @@
"comments": null,
"reference": "GaiaEDR3"
}
],
"RadialVelocities": [
{
"radial_velocity": 44.1289176940918,
"radial_velocity_error": 3.4503207206726074,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
9 changes: 9 additions & 0 deletions data/lhs_207.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,14 @@
"comments": null,
"reference": "GaiaEDR3"
}
],
"RadialVelocities": [
{
"radial_velocity": -22.725605010986328,
"radial_velocity_error": 3.171736001968384,
"adopted": true,
"comments": null,
"reference": "GaiaDR3"
}
]
}
Loading