forked from apache/cordova-plugin-inappbrowser
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to 5.0.0 #1
Open
bradxn
wants to merge
65
commits into
RosePointNav:master
Choose a base branch
from
apache:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OS devices with a notch (#656) * (ios) Removed fake statusbar with hardcoded height to fix issues in iOS devices with a notch * (ios) Removed no longer needed bgToolbar * (ios) Fixed issue with rotation in landscape mode and refactored/simplified the code Co-authored-by: Alessandro Basso <[email protected]>
…-inappbrowser-4.0.0)
(ios): Fix incorrect view height from the second open time
(ios) Add InAppBrowserStatusBarStyle preference. Resolves #728
* ci(travis): update osx xcode image * ci: use travis's latest supported osx_image xcode11.6
PreferredContentMode can now be set with preference config. Since iPadOS came out iPads get a desktop Safari useragent by default. see #687 Co-authored-by: Tim Brust <[email protected]>
Co-authored-by: Tim Brust <[email protected]> Co-authored-by: Mark <[email protected]>
[email protected] makes the WKWebView plugin obsolete. Co-authored-by: Erisu <[email protected]>
* (ios): rename CDVWKProcessPoolFactory CDVWKProcessPoolFactory was integrated from the WKWebView plugin with the new name: CDVWebViewProcessPoolFactory * (ios): Allow both processpool imports
…erAgent (#861) cordova-android adds a space between the default user agent and the custom one: https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214 With this change cordova-androids and the IAB user agent are exactly the same.
bradxn
commented
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Material Design Guidelines says "For most platforms, consider making touch targets at least 48 x 48dp."
* feat(android): Added download event * android typos, whitespaces and whiteline corrected * Update README.md * fix: removed added whitespace trail --------- Co-authored-by: Shaikh Amaan FM <[email protected]> Co-authored-by: Shaikh Amaan FM <[email protected]>
Co-authored-by: joanb-moncasoft <[email protected]>
… This is important in Swift projects, where you cannot use prefix headers. (#927) Co-authored-by: Aleko Petkov <[email protected]>
* remove restoring status bar style code
* chore: bump to next major release 6.0.0 * update Cordova dependencies * bump version just like geolocation https://github.com/apache/cordova-plugin-geolocation/blob/master/package.json#L34-L37 * Update dependencies in package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
Description
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)