-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using changesets to update Announcement.tsx #350
base: main
Are you sure you want to change the base?
Conversation
|
import os | ||
import re | ||
|
||
VERSION = os.environ['VERSION'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling for the case where the VERSION environment variable is not set to prevent a KeyError.
|
||
// Convert changelog entry to JSX-friendly format | ||
const formattedContent = convertMarkdownToJsx(changelogEntry); | ||
formattedContent.replace('{" "}', "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line formattedContent.replace('{" "}', "")
does not modify formattedContent
as strings are immutable. Consider reassigning the result to formattedContent
.
Heads up that I ran prettier on the whole codebase in #404, and it will run automatically in a pre-commit hook going forward. In order to bring this PR up to date on formatting you'll need to run |
Description
Using changesets to update Announcement.tsx
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Automate updates to
Announcement.tsx
andlatestAnnouncementId
inClineProvider.ts
using new scripts and modify workflow to run these scripts for major/minor version changes.update-announcement-id.py
to updatelatestAnnouncementId
inClineProvider.ts
.update-announcement.js
to updateAnnouncement.tsx
with latest changelog entry.changeset-release.yml
to run new scripts for major/minor version changes.Announcement.tsx
using Prettier.Announcement.tsx
to use full version number.markdown-to-jsx
dependency inpackage.json
.This description was created by for 9a78b05. It will automatically update as commits are pushed.