Consistent naming for nodes #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed both on the oficial discord and on the Issue 460, some nodes have inconsistent spelling (ie using the british "grey", as opposed to the american english used everywhere else) and formatting (ie using camelCase or others, instead of the Title Case being used by the majority of nodes).
This PR goes through every node available, changing the name on library and on the nodes themselves to Title Case, and changing existing instances of "Grey" to "Gray"
Changed library names:
Display names
Were changed to match the library names formatting when possible, and abbreviated in some cases, to avoid overly long nodes (ie Edge Detect 2 was changed to AA Edge Detect, to match the library name of Axis Aligned Edge Detect).
Other Changes
Parameter list on the Bricks node was changed to match the new library names
The Curved star parameter on the Shape node was changed to Curved Star
On the FBM node, the Cellular2 through Cellular6 parameter was changed to Cellular 2 ~ Cellular 6
Aliases
Default aliases were added for the british spelling on nodes that uses the word Gray ( > Grey) and Color ( > Colour)
Important to note
The SDF nodes and 3D nodes were not changed in this PR due to the still not discussed inconsistency in their naming
Some of them have sd or TEX3D as a prefix, some do not. some have the prefix both on the library name and the node display name, some will have it only on one of the two.
It's required that we decide what will be the preferred default naming scheme for those nodes before changing them.