-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another PR that needs approval #10
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pkaminski-test asdfh adsf
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adsf
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pkaminski)
|
+documentation +@pkaminski +reviewer:@pkaminski-test @pkaminski-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full publish
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @pkaminski-test)
Previously, pkaminski (Piotr Kaminski) wrote…
another |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+bug
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @pkaminski-test)
-- commits
line 1 at r1:
@pkaminski-test mention in new comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foo
Reviewed 1 of 1 files at r3.
Reviewable status: undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bar
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)
Previously, pkaminski (Piotr Kaminski) wrote…
another
hello
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)
Previously, pkaminski (Piotr Kaminski) wrote…
hello
bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @pkaminski-test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seriously, no.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foo
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bar
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blah.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adsf
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pkaminski)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion
Previously, pkaminski (Piotr Kaminski) wrote…
bar
Code snippet:
adsf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is