Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the type of the scope a generic #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

snoack
Copy link
Contributor

@snoack snoack commented Jan 6, 2024

This change is Reviewable

Copy link
Member

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for Hubkit, I'd like to see client usage before merging.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @snoack)


src/nodefire.ts line 251 at r1 (raw file):

  child<TSource extends Scope = EmptyScope>(
    path: string, scope?: TSource):
  NodeFire<TScope & TSource> {

Nit: line wrap.

Suggestion:

  child<TSource extends Scope = EmptyScope>(
    path: string, scope?: TSource
  ): NodeFire<TScope & TSource> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants