-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-2983: Update doc titles #46
Conversation
This will require an update to the toc file. |
@apinnick , the fails are actually relevant: https://github.com/RedHatSatellite/foreman_theme_satellite/actions/runs/8897047565/job/24431151567?pr=46#step:21:12 |
@ShimShtein That failure is strange. When I checked the failed links manually, they all worked. I am not sure how the "TOC" works, however. |
The TOC file is actually the extract of the documentation links from not-yet-published docs downstream. This is the link structure that will be available later on. So we can anticipate any changes to the doc structure before the docs are actually published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs cherrypick to 6.15!
@evgeni I don't see a stable branch for the 6.15 equivalent version. What is our policy for this repo? |
We don't have any breaking changes since the version that is in 6.15, so I think we can just push whichever the next release will be? |
Apparently the documentation structure is about to change (see the failures in this PR). |
Well, then we'll create a stable branch the moment we're breaking it :) |
I think it's now - the change as it is in the original PR needs to be done to 6.15, and the new TOC + changes that come with it should go to the next version. |
The TOC in this PR, is it for 6.15 or for "develop"? |
The TOC is for |
ok, can we have a toc for 6.15, merge the (test passing) result, then update both to develop and then we have a clean branch point |
Updated the TOC to 6.15 |
Finally all green |
@ShimShtein Thanks! I tried to figure out the problem on my own but didn't succeed. :-( |
Fixes 2983
For 6.16.