Fix compliance policy deployment link #35
Conversation
|
Also cc @Lennonka |
There was a problem hiding this comment.
The link does have a target. However, I'm not sure about its context of origin and, therefore, I cannot evaluate if this target is appropriate.
According to the key of the link, you might want to consider /managing_security_compliance/deploying-compliance-policies_security-compliance, but I'm not blocking it.
|
It's used in Hosts > Compliance > Policies > New Policy We already had this in one of the downstream PRs before the theme plugin got upstreamed. If you say the other link is better, then I'll gladly switch to it. |
|
Then it's already the best possible option! |
| 'deploying-compliance-policies_security-compliance' => "#{ForemanThemeSatellite.documentation_root}/managing_security_compliance/Configuring_SCAP_Contents_security-compliance#deploying-compliance-policies_security-compliance", | ||
| }.freeze | ||
| 'deploying-compliance-policies_security-compliance' => "#{ForemanThemeSatellite.documentation_root}/managing_security_compliance/compliance-policy-deployment-options_security-compliance", | ||
| } |
There was a problem hiding this comment.
Any reason you dropped the .freeze?
There was a problem hiding this comment.
Fat fingers I'm afraid, frozen again.
adamruzicka
force-pushed
the
compliance-link
branch
from
830f4c7 to
0c49bf7
Compare
CC @pondrejk