Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry): Avoid sentry plugin install on dev set up #2353

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adonispuente
Copy link
Contributor

Whenever you run compliance locally, the plugin uploads debugIds, this doesnt affect functionality but is unnecessary and prolongs start up time locally. These variables are always available to master branch as secrets, so the plugin will load in every time master is built, as well as pass in the auth token when its defined

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.01%. Comparing base (e1ffacc) to head (f1c326f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2353   +/-   ##
=======================================
  Coverage   67.01%   67.01%           
=======================================
  Files         360      361    +1     
  Lines        6463     6473   +10     
  Branches     2068     2068           
=======================================
+ Hits         4331     4338    +7     
- Misses       2132     2135    +3     
Flag Coverage Δ
combined 67.01% <ø> (+<0.01%) ⬆️
cypress 42.73% <ø> (ø)
jest 66.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants