Skip to content

Commit

Permalink
chore: clear some ts warning
Browse files Browse the repository at this point in the history
  • Loading branch information
vvvvvv1vvvvvv committed Sep 26, 2021
1 parent 6145a5c commit 21a874b
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 18 deletions.
4 changes: 2 additions & 2 deletions src/background/service/keyring/eth-watch-keyring.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class WatchKeyring extends EventEmitter {
);
};

return new Promise((resolve, reject) => {
return new Promise((resolve) => {
this.resolvePromise = resolve;
});
}
Expand Down Expand Up @@ -230,7 +230,7 @@ class WatchKeyring extends EventEmitter {
});
}

async signTypedData(address: string, data, options) {
async signTypedData(address: string, data) {
await this.initWalletConnect();

this.onAfterConnect = async (error, payload) => {
Expand Down
2 changes: 1 addition & 1 deletion src/background/service/transactionHistory.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createPersistStore } from 'background/utils';
import maxBy from 'lodash/maxBy';
import openapiService, { Tx, ExplainTxResponse } from './openapi';
import { CHAINS, CHAINS_ENUM } from 'consts';
import { CHAINS } from 'consts';

export interface TransactionHistoryItem {
rawTx: Tx;
Expand Down
2 changes: 1 addition & 1 deletion src/ui/views/Approval/components/AddChain.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import clsx from 'clsx';
import { Button } from 'antd';
import { useTranslation, Trans } from 'react-i18next';
import { intToHex } from 'ethereumjs-util';
import { CHAINS, CHAINS_ENUM } from 'consts';
import { CHAINS_ENUM } from 'consts';
import { Chain } from 'background/service/chain';
import { useWallet, useApproval } from 'ui/utils';
import IconWarning from 'ui/assets/warning.svg';
Expand Down
2 changes: 0 additions & 2 deletions src/ui/views/Approval/components/WatchAdrressWaiting.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ const WatchAddressWaiting = ({ params }: { params: ApprovalParams }) => {
WALLETCONNECT_STATUS_MAP.WAITING,
];
const wallet = useWallet();
const [address, setAddress] = useState<string | null>(null);
const [connectStatus, setConnectStatus] = useState(
WALLETCONNECT_STATUS_MAP.PENDING
);
Expand Down Expand Up @@ -346,7 +345,6 @@ const WatchAddressWaiting = ({ params }: { params: ApprovalParams }) => {
(await wallet.getWatchAddressPreference(account.address)) || 0
);
setIsSignText(approval?.approvalType !== 'SignTx');
setAddress(account.address);
eventBus.addEventListener(EVENTS.SIGN_FINISHED, async (data) => {
if (data.success) {
await wallet.setWatchAddressPreference(account.address, currentType);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Button } from 'antd';
import { useTranslation } from 'react-i18next';
import { useWallet, openInTab } from 'ui/utils';
import { Modal } from 'ui/component';
import { IconDebank } from 'ui/assets';
import { wrapModalPromise } from 'ui/component/AuthenticationModal';
import { WalletController } from 'background/controller/wallet';
import { query2obj, obj2query } from 'ui/utils/url';
Expand All @@ -12,14 +11,12 @@ const ConfirmOpenExternalModal = ({
onFinished,
onCancel,
origin = 'https://debank.com',
icon = IconDebank,
wallet,
}: {
onFinished(): void;
onCancel(): void;
wallet: WalletController;
origin?: string;
icon?: string;
}) => {
const [visible, setVisible] = useState(true);
const { t } = useTranslation();
Expand Down Expand Up @@ -69,7 +66,7 @@ const funConfirmOpenExternalModal = wrapModalPromise(ConfirmOpenExternalModal);
const useConfirmExternalModal = () => {
const wallet = useWallet();

return (url: string) => {
return async (url: string) => {
const origin = url.split('?')[0];
const openUrl =
origin +
Expand All @@ -78,7 +75,7 @@ const useConfirmExternalModal = () => {
...query2obj(url),
utm_source: 'rabby',
});
if (wallet.getExternalLinkAck()) {
if (await wallet.getExternalLinkAck()) {
openInTab(openUrl);
return;
}
Expand Down
2 changes: 0 additions & 2 deletions src/ui/views/ImportHardware/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import React, { useState } from 'react';
import { useTranslation } from 'react-i18next';
import { useHistory } from 'react-router-dom';
import { StrayPage } from 'ui/component';
import { useWallet } from 'ui/utils';
import { SvgIconOnekey, SvgIconTrezor, ImportLedgerIcon } from 'ui/assets';
import { BIP44_PATH } from './LedgerHdPath';
import { IS_CHROME, KEYRING_CLASS } from 'consts';

import './index.css';
Expand Down
7 changes: 3 additions & 4 deletions src/ui/views/Settings/index.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import React, { useEffect, useState } from 'react';
import React from 'react';
import { useHistory } from 'react-router-dom';
import { Form, Input, Button } from 'antd';
import { Button } from 'antd';
import { useTranslation } from 'react-i18next';
import { useWallet } from 'ui/utils';
import { PageHeader, Field, Modal } from 'ui/component';
import { INITIAL_OPENAPI_URL } from 'consts';
import { PageHeader, Field } from 'ui/component';
import IconAddressManagement from 'ui/assets/address-management.svg';
import IconChainManagement from 'ui/assets/chain-management.svg';
import IconConnectSitesManagement from 'ui/assets/connect-sites-management.svg';
Expand Down
2 changes: 1 addition & 1 deletion src/ui/views/Unlock/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Unlock = () => {
inputEl.current.focus();
}, []);

const [run, loading] = useWalletRequest(wallet.unlock, {
const [run] = useWalletRequest(wallet.unlock, {
onSuccess() {
resolveApproval();
},
Expand Down

0 comments on commit 21a874b

Please sign in to comment.