Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove module 14_BresserTemeo.pm and associated tests #1294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    Protocol 44 BresserTemeo has been in module 14_SD_WS.pm for a long time.
    Codecov coverage for this module is only 9.17%.

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

elektron-bbs and others added 2 commits January 26, 2025 20:51
Module 14_BresserTemeo.pm and associated tests removed
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (ac0180d) to head (88e6fe6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   86.39%   86.77%   +0.37%     
==========================================
  Files         138      137       -1     
  Lines       10313    10206     -107     
  Branches     1699     1677      -22     
==========================================
- Hits         8910     8856      -54     
+ Misses       1402     1349      -53     
  Partials        1        1              
Flag Coverage Δ
fhem 79.12% <ø> (+0.61%) ⬆️
modules 86.77% <ø> (+0.37%) ⬆️
perl 95.65% <ø> (-0.82%) ⬇️
unittests 86.77% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elektron-bbs elektron-bbs requested a review from sidey79 January 26, 2025 20:20
@elektron-bbs
Copy link
Contributor Author

Bringt zwar für das gesamte Projekt nicht viel, aber Kleinvieh macht auch Mist :-)
codecov/project — 83.59% (+0.44%) compared to ac0180d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants