Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple item documentation #37

Merged
merged 14 commits into from
Aug 30, 2022
Merged

Add simple item documentation #37

merged 14 commits into from
Aug 30, 2022

Conversation

mounderfod
Copy link

@mounderfod mounderfod commented Aug 18, 2022 •
edited
Loading

Your First Item documentation which explains the very basics of item creation.
I intend to create three more pages:

  • Beyond the Basics: full, in-depth detail of all of the things briefly covered in the first tutorial, e.g. item settings, models, etc. Still uses the default item class.
  • Custom Item Types: advanced, an explanation on making your own class extending Item for custom behaviour.
  • Item Recipes (unsure whether this will go in item or recipe): In-depth info about the various recipe types for items.

This PR is related to #3 but does not fully finish the Items wiki, so does not close it.

ghost
ghost reviewed Aug 18, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor things

OroArmor
OroArmor approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@mounderfod mounderfod requested a review from a user August 18, 2022 20:18
@mounderfod
Copy link
Author

Just made several commits which should hopefully resolve all the issues.

@mounderfod
Proofreading 6
b74635d 
Co-authored-by: Alkya <[email protected]>
@mounderfod
Copy link
Author

Has anyone else spotted any problems with the PR or is it good to go?

ix0rai
ix0rai approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few little nitpicks!

@mounderfod @ix0rai
Proofreading 7
2039ae4 
Co-authored-by: ix0rai <[email protected]>
@mounderfod
Copy link
Author

Latest commit should fix all of that :)

@mounderfod @OroArmor
Yeet the properties!
ea39bf1 
Co-authored-by: Eli Orona <[email protected]>
@mounderfod
Copy link
Author

Is this now ready for merge?

@OroArmor OroArmor merged commit 3bfa8ea into QuiltMC:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OroArmor OroArmor OroArmor approved these changes

@pluiedev pluiedev pluiedev approved these changes

@Mysterious-Dev Mysterious-Dev Mysterious-Dev approved these changes

@ix0rai ix0rai ix0rai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mounderfod @OroArmor @pluiedev @Mysterious-Dev @ix0rai