Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added debug info option when building numpy #126

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Added debug info option when building numpy #126

merged 3 commits into from
Jan 13, 2025

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Jan 10, 2025 •
edited
Loading

Description:

  • Added debug info option when building numpy
  • It may happen that people are less familiar with meson and how to pass args

@vfdev-5
Update debugging.md
cce6126 
Added debug info option when building numpy
@vfdev-5
Update debugging.md
f90125b
@vfdev-5 vfdev-5 marked this pull request as ready for review January 10, 2025 19:23
ngoldbaum
ngoldbaum approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth adding if it confused you.

@rgommers rgommers added the documentation Improvements or additions to documentation label Jan 13, 2025
rgommers
rgommers approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfdev-5

docs/debugging.md Outdated Show resolved Hide resolved
@rgommers rgommers merged commit 9e6184a into Quansight-Labs:main Jan 13, 2025
2 checks passed
@vfdev-5 vfdev-5 deleted the patch-2 branch January 13, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @rgommers @ngoldbaum