Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel.ad_break.begin for EventSub #464

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

Aluerie
Copy link
Contributor

@Aluerie Aluerie commented Aug 7, 2024

Description

Hey, I'm Irene Adler❤️ from discord, coming from a small discussion in #help - just threw together some implementation for channel.ad_break.begin subscription type for Event Sub.

The link to twitch dev docs: https://dev.twitch.tv/docs/eventsub/eventsub-subscription-types/#channelad_breakbegin

Checklist

  • If code changes were made then they have been tested.
    Little proof:
    image
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@Aluerie Aluerie changed the title Introduce channel.ad_break.begin for EventSub Add channel.ad_break.begin for EventSub Aug 8, 2024
docs/exts/eventsub.rst Show resolved Hide resolved
Sorry, I m noob in docs and stuff
@Aluerie Aluerie requested a review from EvieePy September 4, 2024 20:41
@EvieePy EvieePy merged commit 77ef79d into PythonistaGuild:master Sep 7, 2024
8 checks passed
@EvieePy
Copy link
Member

EvieePy commented Sep 7, 2024

Thanks 👍

@Aluerie Aluerie deleted the ad-break-event branch September 8, 2024 10:00
EvieePy added a commit that referenced this pull request Nov 12, 2024
* Introduce `channel.ad_break.begin` for EventSub

Implementation for this subscription type: https://dev.twitch.tv/docs/eventsub/eventsub-subscription-types/#channelad_breakbegin

* Fix docs mess-up

Sorry, I m noob in docs and stuff

Co-authored-by: Irene Adler❤ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants