feat(ext.bridge): add walk command functions & dynamically fetch attrs in commands variants #1867
Conversation
Lulalaby
changed the title
Signed-off-by: Middledot <[email protected]>
for more information, see https://pre-commit.ci
As mentioned in https://docs.python.org/3.11/library/typing.html#typing.Generator, the Iterable and Iterator types can also be used in generator functions
BobDotCom
changed the title
for more information, see https://pre-commit.ci
Lulalaby
requested review from
Dorukyum and
plun1331
and removed request for
JustaSqu1d
Signed-off-by: Middledot <[email protected]>
for more information, see https://pre-commit.ci
|
After reviewing this, I don't remember why I said it depends on the other pr, so it can be reviewed and merged now |
Signed-off-by: Middledot <[email protected]>
|
wait for bob to review tho |
|
I updated the description explaining what I just did |
|
Nom Looks good |
|
@Lulalaby @BobDotCom Please review (then we can also get #1866 merged) |
Signed-off-by: Lala Sabathil <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1867 +/- ##
==========================================
+ Coverage 33.23% 33.26% +0.02%
==========================================
Files 97 97
Lines 19038 19021 -17
==========================================
Hits 6328 6328
+ Misses 12710 12693 -17
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Summary
Further explanations in the changelog.
Should fix #1840
EDIT: The translation attributes are unique to slash commands so if you "dynamically" set them:
So I kept the code for setting and fetching the translations.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.