-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 1088 refactor Workers out of SSR builds #1110
Merged
thescientist13
merged 14 commits into
release/0.29.0
from
enhancement/issue-1088-refactor-workers-out-of-SSR-builds
Jun 29, 2023
Merged
Enhancement/issue 1088 refactor Workers out of SSR builds #1110
thescientist13
merged 14 commits into
release/0.29.0
from
enhancement/issue-1088-refactor-workers-out-of-SSR-builds
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
CLI
SSR
labels
May 16, 2023
This was referenced May 16, 2023
This was referenced Jun 18, 2023
thescientist13
changed the title
Enhancement/issue 1088 refactor workers out of ssr builds
Enhancement/issue 1088 refactor workers out of SSR builds
Jun 25, 2023
This was referenced Jun 25, 2023
thescientist13
force-pushed
the
enhancement/issue-1088-refactor-workers-out-of-SSR-builds
branch
from
June 29, 2023 01:28
7f8d9d7
to
27a9c22
Compare
thescientist13
deleted the
enhancement/issue-1088-refactor-workers-out-of-SSR-builds
branch
June 29, 2023 01:46
thescientist13
changed the title
Enhancement/issue 1088 refactor workers out of SSR builds
Enhancement/issue 1088 refactor Workers out of SSR builds
Jun 29, 2023
thescientist13
added a commit
that referenced
this pull request
Aug 12, 2023
* production SSR workers refactor WIP * initial draft refactoring for no Workers as part of serving SSR builds * decouple SSR module execution from Workers implementation * enable pre-compiled HTML for templates during SSR * ammed static router spec for execute-route-module * get SSR execution module from config * refactor executeRouteModule signature and fix all specs * update lit renderer per execute module refactoring * pre-bundle SSR entry points * refactor entry file to use runtime import.meta.url * use placholder for SSR page entry point path and replace at write with rollup * expand rollup and lit circular reference TODO comment * clean up console logs and track TODOs * update Renderer plugin docs
thescientist13
added a commit
that referenced
this pull request
Nov 9, 2023
* production SSR workers refactor WIP * initial draft refactoring for no Workers as part of serving SSR builds * decouple SSR module execution from Workers implementation * enable pre-compiled HTML for templates during SSR * ammed static router spec for execute-route-module * get SSR execution module from config * refactor executeRouteModule signature and fix all specs * update lit renderer per execute module refactoring * pre-bundle SSR entry points * refactor entry file to use runtime import.meta.url * use placholder for SSR page entry point path and replace at write with rollup * expand rollup and lit circular reference TODO comment * clean up console logs and track TODOs * update Renderer plugin docs
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
CLI
documentation
Greenwood specific docs
enhancement
Improve something existing (e.g. no docs, new APIs, etc)
Plugins
Greenwood Plugins
SSR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1088
Summary of Changes
References
TODO
executeModule
for custom implementations like Lit (do we have to handle a renderer and an adapter plugin at the same time?) and for developmentexecuteRouteModule
from configexecuteModule
signature (pass in entirepage
)executeModuleUrl
in our wrapper bundles? Can we bundle down into one file instead?os
/ thread pooling for prerendering? - deferred to performance benchmarking / optimizing Greenwood #970 and Encapsulating SSR Rendering (Isolation Mode) #1117Questions
getTemplate
has to be a "static" function (for now) but maybe we will deprecating anyways as part of Layouts (Templates) and Pages #955 ? - deferred to Static and Serverless Hosting Runtime Adapters #1008import.meta.url
? - deferred to - Static and Serverless Hosting Runtime Adapters #1008 (comment)