Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 948 web api standardization windows compat refactor #1047

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 1, 2023

Related Issue

#948 / #1045

Summary of Changes

Specifically a subset of changes to ensure windows compat

  1. Make everything URL for fs calls through and through (should address Windows compat and a bunch of TODOs in 948)

TODO

  1. Verify Windows compat / CI
  2. Restore lint and best way to do try / catch for fs.access refactor
  3. clean up console logging / TODOs / comments

@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Feb 1, 2023
@thescientist13 thescientist13 changed the title Feature/issue 948 web api standardization win Feature/issue 948 web api standardization windows compat refactor Feb 1, 2023
@thescientist13 thescientist13 self-assigned this Feb 4, 2023
@thescientist13 thescientist13 merged commit 65457e9 into feature/issue-948-web-api-standardization Feb 4, 2023
@thescientist13 thescientist13 deleted the feature/issue-948-web-api-standardization-win branch February 4, 2023 20:11
@thescientist13 thescientist13 linked an issue Feb 4, 2023 that may be closed by this pull request
3 tasks
@thescientist13 thescientist13 added the documentation Greenwood specific docs label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize on Web APIs (Request / Response / URL / etc)
1 participant