Skip to content

Commit

Permalink
expand rollup and lit circular reference TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
thescientist13 committed Jun 21, 2023
1 parent 5c22593 commit f1103b8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/cli/src/config/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ const getRollupConfigForSsr = async (compilation, input) => {
switch (code) {

case 'CIRCULAR_DEPENDENCY':
// TODO let this through for lit to enable nodeResolve({ preferBuiltins: true })
// TODO let this through for lit by suppressing it
// Error: the string "Circular dependency: ../../../../../node_modules/@lit-labs/ssr/lib/render-lit-html.js ->
// ../../../../../node_modules/@lit-labs/ssr/lib/lit-element-renderer.js -> ../../../../../node_modules/@lit-labs/ssr/lib/render-lit-html.js\n" was thrown, throw an Error :)
// https://github.com/lit/lit/issues/449
break;
default:
Expand Down

0 comments on commit f1103b8

Please sign in to comment.