Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly states in tutorials train_controlnet #1919

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaybeRichard
Copy link

Fixes # .

Description

The current documentation incorrectly states that "fold 0 is used for training" in the prepare_maisi_controlnet_json_dataloader function. In reality, the function uses the fold parameter to determine the validation set based on matching fold indices. Specifically, if a dataset item's fold value matches the fold value specified in config_maisi_controlnet_train.json, it is assigned to the validation set; otherwise, it is used for training.

Changes

  • Updated Documentation:
    • Revised the description of the fold parameter to accurately reflect its functionality.
    • Clarified that in the current parameter settings, fold 0 is designated for validation and fold 1 is designated for training.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericspod ericspod requested a review from KumoLiu January 13, 2025 01:10
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM.

@KumoLiu KumoLiu enabled auto-merge (squash) January 13, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants