Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vista3d dataset creation #9

Merged
merged 8 commits into from
Sep 27, 2024
Merged

vista3d dataset creation #9

merged 8 commits into from
Sep 27, 2024

Conversation

holgerroth
Copy link
Collaborator

No description provided.

@mingxin-zheng
Copy link
Collaborator

Hi @holgerroth , I merged the static fix PR #8 just now. There are some new issues in ./monai_vila2d/data_prepare/experts/torchxrayvision/make_ensemble_probs.py that's recently merged. May I ask if you can add the license header and fix the static test issue in your PR? Thanks!

$ isort --check-only --diff .  # using the configuration in pyproject.toml
ERROR: /localhome/local-mingxinz/nvidia/VLM/monai_vila2d/data_prepare/experts/torchxrayvision/make_ensemble_probs.py Imports are incorrectly sorted and/or formatted.
--- /localhome/local-mingxinz/nvidia/VLM/monai_vila2d/data_prepare/experts/torchxrayvision/make_ensemble_probs.py:before        2024-09-24 02:04:57.651304
+++ /localhome/local-mingxinz/nvidia/VLM/monai_vila2d/data_prepare/experts/torchxrayvision/make_ensemble_probs.py:after 2024-09-24 02:05:55.519599
@@ -2,7 +2,6 @@
 from glob import glob
 
 from monai.bundle.config_parser import ConfigParser
-
 from torchxray_cls import all_models, cls_models
 
 input_dir = "/data/datasets/mimic-cxr/torchxrayvision/"

@wyli wyli mentioned this pull request Sep 24, 2024
mingxin-zheng pushed a commit that referenced this pull request Sep 24, 2024
fixes format and license 

#9 (comment)

Signed-off-by: Wenqi Li <[email protected]>
@mingxin-zheng
Copy link
Collaborator

mingxin-zheng commented Sep 24, 2024

Issue above was addressed by #10 . Thanks @wyli !

@holgerroth holgerroth marked this pull request as ready for review September 27, 2024 20:37
@holgerroth holgerroth enabled auto-merge (squash) September 27, 2024 20:43
Copy link
Collaborator

@finalelement finalelement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth holgerroth merged commit b74d7e4 into main Sep 27, 2024
2 checks passed
@holgerroth holgerroth deleted the create_vista3d branch September 27, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants