Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved API library version API #173

Closed
PortAudio-admin opened this issue Mar 22, 2011 · 5 comments
Closed

Improved API library version API #173

PortAudio-admin opened this issue Mar 22, 2011 · 5 comments
Labels
LIST-REVIEW Requires open review/discussion on the mailing list P3 Priority: Normal public-api The public API defined in include/PortAudio.h
Milestone

Comments

@PortAudio-admin
Copy link
Collaborator

Issue created by @RossBencina

The current library version API is not useful enough to support clients that are compatible with multiple library versions. Ticket #172 covers removing structVersion fields (and links to discussion about why they aren't very usefull in practice).

Ross proposed a global version number API here, but it wasn't really discussed in detail
http://music.columbia.edu/pipermail/portaudio/2008-February/008332.html

void Pa_GetVersion( int *major, int *minor, int *point );

There is also a request to provide #defines in the header file (PA_LIBRARY_VERSION_MAJOR, etc) so that code can detect the version at compile time.

More discussion here:
http://music.columbia.edu/pipermail/portaudio/2008-February/008340.html

Richard Ash wrote:

We can drop the int Pa_GetVersion(void) function altogether
(can't think of a use for it,
programs shoudl check API version not implementation version)."

@PortAudio-admin
Copy link
Collaborator Author

Comment by @philburk

It's nice to have a single integer containing the version. Something like:

versionCode = (major<<16) + (minor<<8) + point

@PortAudio-admin
Copy link
Collaborator Author

Comment by @RossBencina

TRAC migration: propagating ticket status from TRAC

@PortAudio-admin
Copy link
Collaborator Author

Comment by @robiwano

This seems to be fixed by recent commit: https://www.assembla.com/code/portaudio/subversion/changesets/1922#commit/comment:771023/line:9/path:portaudio/branches/versioning/src/common/pa_front.c

Also, SVN revision can be included with:

const char* paSvnRevision = "$Revision: $";

which will expand to f.i.

const char* paSvnRevision = "$Revision: 1922 $";

when committing it.

@PortAudio-admin
Copy link
Collaborator Author

Comment by @philburk

Fixed in 2014

@PortAudio-admin
Copy link
Collaborator Author

Issue closed by @philburk

@PortAudio-admin PortAudio-admin added P3 Priority: Normal LIST-REVIEW Requires open review/discussion on the mailing list public-api The public API defined in include/PortAudio.h labels Sep 24, 2020
@PortAudio-admin PortAudio-admin added this to the V19-M2 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LIST-REVIEW Requires open review/discussion on the mailing list P3 Priority: Normal public-api The public API defined in include/PortAudio.h
Projects
None yet
Development

No branches or pull requests

1 participant