Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

DOMs : Add schema to complete the text explanation #1690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DOMs : Add schema to complete the text explanation #1690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions app/1.0/docs/devguide/local-dom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,25 @@ when manipulating DOM from JavaScript. This interface covers most of the
common DOM methods and properties, and is compatible with both shady DOM and
native shadow DOM.

```html
<dom-module>
<template>

<!--
Local DOM. Possible implementations :
- Shadow DOM (browser implementation)
- Shady DOM (Polymer implementation)
-->

<content>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<content> should be <slot> now...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a suggested edit to a 1.0 doc so it should stay <content>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should keep it <content> even though 1.7+ can make use of slots and reduces changes going to 2.0?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯ Or note hybrid syntax?

<!--
Light DOM
-->
</content>

</template>
</dom-module>
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems not quite right about this. I will try to explain my thoughts.

I read the the comments in the <template> section as instructing me to insert my own code here, and that my code must be either:

  • A "Shadow DOM (browser implementation)", or
  • A "Shady DOM (Polymer implementation)"

I would not know what either of these things are, or how to write them.

Thus I find this suggested addition to be more confusing rather than clarifying.

But I will ask @arthurevans to comment here and will trust his opinion on the matter.


**Note:** Currently Polymer uses shady DOM by default on all
browsers. To opt-in to using shadow DOM where available, see [Global
Expand Down