-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox/Brave support + battery optimisation #24
base: master
Are you sure you want to change the base?
Conversation
- Limit accessibility events to 1 per second to reduce battery drain
…arget sdk that works
Should also note the 1000ms timeout might be a bit too generous, it can require some tapping on/off fields before the notification appears. Could probably get away with reducing that quite a bit without impacting on battery too much |
Unfortunately I have never programmed for Android and I have no knowledge of Java so I can't do that myself, but it should also be quite easy to add support for a lot of other browsers. See how this file in another project dealt with browser support. |
Would be awesome if this could be merged, I'd really want that Brave support. |
I've now moved on to the native integration in latest android/firefox/kp2a, no need for this any more, anyone can take over this as necessary |
Hi @lukefor, I am also interested in this Brave Browser support! :) But it looks like @PhilippC hasn't been active for a quite long time on the initial project. I am not familiar with Android compiling and I was wondering, what are the tools you used to build the apk file? Maybe you could release an apk file and link to it in your README? That would be awesome! |
@lukefor: unfortunately I use Chrome under Android. |
The original plug-in already works for Chrome :) |
Yeah, but always crashes :-( |
@PhilippC would be really nice if you could review this and merge it. Brave browser is now an important Browser. What is your IDE btw? I did try to import the project into Android Studio and build the APK myself but it didn't work. Thank you! |
Hello world |
Hhh |
Can this work with kiwi browser? (Chromium) |
I've added support for Firefox and Brave (issues #19, #23, #11), and also reduced the CPU usage and performance impact from noticeable to virtually nil - no longer appears in battery stats at all! (issue #17)
Apologies this is a bit of a messy pull request, going to be some manual merging needed here I think. The only changes of any significance are in
AutoFillService.java
andaccserviceconfig.xml
, everything else is just getting it to build on my version of VS