Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox/Brave support + battery optimisation #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lukefor
Copy link

@lukefor lukefor commented Feb 16, 2019

I've added support for Firefox and Brave (issues #19, #23, #11), and also reduced the CPU usage and performance impact from noticeable to virtually nil - no longer appears in battery stats at all! (issue #17)

Apologies this is a bit of a messy pull request, going to be some manual merging needed here I think. The only changes of any significance are in AutoFillService.java and accserviceconfig.xml, everything else is just getting it to build on my version of VS

lukefor added 3 commits July 17, 2018 13:44
- Limit accessibility events to 1 per second to reduce battery drain
@lukefor
Copy link
Author

lukefor commented Feb 24, 2019

Should also note the 1000ms timeout might be a bit too generous, it can require some tapping on/off fields before the notification appears. Could probably get away with reducing that quite a bit without impacting on battery too much

@renyhp
Copy link

renyhp commented Mar 12, 2019

Unfortunately I have never programmed for Android and I have no knowledge of Java so I can't do that myself, but it should also be quite easy to add support for a lot of other browsers. See how this file in another project dealt with browser support.

@antgustech
Copy link

Would be awesome if this could be merged, I'd really want that Brave support.

@lukefor
Copy link
Author

lukefor commented Aug 8, 2019

I've now moved on to the native integration in latest android/firefox/kp2a, no need for this any more, anyone can take over this as necessary

@JulesLecuir
Copy link

Hi @lukefor, I am also interested in this Brave Browser support! :) But it looks like @PhilippC hasn't been active for a quite long time on the initial project. I am not familiar with Android compiling and I was wondering, what are the tools you used to build the apk file? Maybe you could release an apk file and link to it in your README? That would be awesome!

@klorinczi
Copy link

@lukefor: unfortunately I use Chrome under Android.
Would be useful to have solution for Chrome, too.

@JulesLecuir
Copy link

The original plug-in already works for Chrome :)

@klorinczi
Copy link

klorinczi commented Jan 6, 2020

Yeah, but always crashes :-(
See:
PhilippC/keepass2android#281

@AlexandreMarkus
Copy link

@PhilippC would be really nice if you could review this and merge it. Brave browser is now an important Browser. What is your IDE btw? I did try to import the project into Android Studio and build the APK myself but it didn't work. Thank you!

@Bemnyjasha
Copy link

Hello world

@Bemnyjasha
Copy link

Hhh

@4-FLOSS-Free-Libre-Open-Source-Software

Can this work with kiwi browser? (Chromium)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants