Skip to content

Commit

Permalink
Add citation-file-formatting repository as submodule (asreview#894)
Browse files Browse the repository at this point in the history
  • Loading branch information
Otto Mättas authored Dec 15, 2021
1 parent 7e36413 commit 7783aa2
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/ci-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
name: lint-python
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
- uses: actions/setup-python@v1
with:
python-version: '3.8'
Expand All @@ -20,7 +20,9 @@ jobs:
name: test-minimal-deps
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
with:
submodules: recursive
- uses: actions/setup-python@v1
with:
python-version: '3.8'
Expand All @@ -36,7 +38,9 @@ jobs:
name: test-full-deps
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
with:
submodules: recursive
- uses: actions/setup-python@v1
with:
python-version: '3.8'
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "tests/citation-file-formatting"]
path = tests/citation-file-formatting
url = https://github.com/asreview/citation-file-formatting.git
11 changes: 11 additions & 0 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@ Build the project from source with the following code.

## Development workflow

### Git Submodules
Some demo datasets are included as a submodule. Directory [asreview/tests/citation-file-formatting](https://github.com/ottomattas/asreview/tree/development-v1/tests) is cloned from [citation-file-formatting](https://github.com/asreview/citation-file-formatting).

Examples:
- To clone the full repository with submodules in one line, add `--recursive` flag:

```git clone --recursive git://github.com/asreview/asreview.git```

- To update the submodule, you would still need to follow the contribution guide in the submodule repository. And then create a PR for the main repository with the updated submodule commit.


### Back end
Install Python

Expand Down
1 change: 1 addition & 0 deletions tests/citation-file-formatting

0 comments on commit 7783aa2

Please sign in to comment.