Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code it first runs the command (make, test_harness, ...) and when it's complete it may 'log' all the output on STDOUT/smokecurrent.log.
What I like more is if the output shows when things are happening instead of needing to wait until the command fully completed.
With this patch that does happen for
make
make test_harness
I consider this to be WIP because:
a) Should this behavior be configurable?
b) For
_run_harness3_target
(and others) it uses a pipe and thenreads from it. I'm guessing that it should be possible to replace
the code with
capture
(ortee
) from Capture::Tiny but I don'tknow if that is desirable.
c) On Windows some output is now duplicated in the log because stdout
of
make
is already logged (see$make_output
insub make_
).d) This is incomplete: only '_run_harness3_target' was updated but
other code has the same structure.
e) It causes the messages (from make, test_harness3) to be logged
without timestamp. Before if the output of make was logged (for
example on Windows) all messages were logged with the same timestamp.
(Ideally each message would have a timestamp of when it happened but
that might not be feasible with Capture::Tiny)