Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option generate-krb5-file for krb5 configuration #544

Merged
merged 3 commits into from
Jan 18, 2025
Merged

Add option generate-krb5-file for krb5 configuration #544

merged 3 commits into from
Jan 18, 2025

Conversation

mpgn
Copy link
Collaborator

@mpgn mpgn commented Jan 18, 2025

Description

This PR add the option generate-krb5-file like generate-hosts-file to generate a valid krb5.conf file in order to do kerberos with other tool.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Agains goad lab

image

Checklist:

  • I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary
  • New and existing e2e tests pass locally with my changes
  • My code follows the style guidelines of this project (should be covered by Ruff above)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@mpgn mpgn merged commit 9511ca2 into main Jan 18, 2025
4 checks passed
@mpgn mpgn deleted the krb5 branch January 18, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants