Remove smb from ldap proto #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpgn
requested review from
zblurx,
Marshall-Hallenbeck and
NeffIsBack
as code owners
lodos2005
added a commit
to lodos2005/NetExec
that referenced
this pull request
Dec 25, 2024
NeffIsBack
added a commit
that referenced
this pull request
Dec 26, 2024
Rename ldapConnection to the new ldap_connection var #508 #4767762 - Fix Modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actually, ldap proto is using SMB to get host information. Using the PR of @XiaoliChan #245 I've added only the interesting part to avoid any breaking change but removing smb.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Against GOAD lab
Screenshots (if appropriate):
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)