Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[winrm] better output #114

Merged
merged 8 commits into from
Dec 10, 2023
Merged

[winrm] better output #114

merged 8 commits into from
Dec 10, 2023

Conversation

XiaoliChan
Copy link
Contributor

As @NeffIsBack feedback, shouldn't show WINRM when doing SMB enumeration.

What news:

  • get auth type from HTTP header WWW-Authenticate

image

@XiaoliChan
[winrm] better output
76f23d4 
Signed-off-by: XiaoliChan <[email protected]>
@Marshall-Hallenbeck Marshall-Hallenbeck changed the base branch from develop to main November 13, 2023 15:17
@NeffIsBack NeffIsBack added bug-fix This Pull Request fixes a bug tested reviewed code Label for when a static code review was done labels Dec 9, 2023
@NeffIsBack
Copy link
Contributor

Working :)
image

NeffIsBack
NeffIsBack approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeffIsBack NeffIsBack merged commit 4846464 into Pennyw0rth:main Dec 10, 2023
1 check passed
@XiaoliChan XiaoliChan deleted the winrm-better-output branch December 12, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeffIsBack NeffIsBack NeffIsBack approved these changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@Marshall-Hallenbeck Marshall-Hallenbeck Awaiting requested review from Marshall-Hallenbeck Marshall-Hallenbeck is a code owner

@mpgn mpgn Awaiting requested review from mpgn mpgn is a code owner

Assignees
No one assigned
Labels
bug-fix This Pull Request fixes a bug reviewed code Label for when a static code review was done tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XiaoliChan @NeffIsBack @Marshall-Hallenbeck