Add void return type to all methods

Payum · Nov 7, 2023 · 8348e00 · 8348e00
1 parent dd2aa53
commit 8348e00
Show file tree

Hide file tree

Showing 18 changed files with 64 additions and 64 deletions.
diff --git a/Action/CaptureAction.php b/Action/CaptureAction.php
@@ -31,7 +31,7 @@ public function __construct()
     /**
      * @param Capture $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Action/CaptureOffsiteAction.php b/Action/CaptureOffsiteAction.php
@@ -34,7 +34,7 @@ public function __construct()
     /**
      * @param Capture $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Action/CaptureOffsiteNullAction.php b/Action/CaptureOffsiteNullAction.php
@@ -21,7 +21,7 @@ class CaptureOffsiteNullAction implements ActionInterface, GatewayAwareInterface
     /**
      * @param Capture $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Action/ConvertPaymentAction.php b/Action/ConvertPaymentAction.php
@@ -13,7 +13,7 @@ class ConvertPaymentAction implements ActionInterface
     /**
      * @param Convert $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Action/NotifyAction.php b/Action/NotifyAction.php
@@ -28,7 +28,7 @@ public function __construct()
     /**
      * @param Notify $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Action/NotifyNullAction.php b/Action/NotifyNullAction.php
@@ -18,7 +18,7 @@ class NotifyNullAction implements ActionInterface, GatewayAwareInterface
     /**
      * @param Notify $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Action/StatusAction.php b/Action/StatusAction.php
@@ -14,7 +14,7 @@ class StatusAction implements ActionInterface
     /**
      * @param GetStatusInterface $request
      */
-    public function execute($request)
+    public function execute($request): void
     {
         RequestNotSupportedException::assertSupports($this, $request);
 

diff --git a/Api.php b/Api.php
@@ -264,7 +264,7 @@ protected function doRequest(array $fields)
         return $result;
     }
 
-    protected function addGlobalParams(array &$params)
+    protected function addGlobalParams(array &$params): void
     {
         $params['VERSION'] = self::VERSION;
         $params['IDENTIFIER'] = $this->options['identifier'];

diff --git a/Be2BillDirectGatewayFactory.php b/Be2BillDirectGatewayFactory.php
@@ -10,7 +10,7 @@
 
 class Be2BillDirectGatewayFactory extends GatewayFactory
 {
-    protected function populateConfig(ArrayObject $config)
+    protected function populateConfig(ArrayObject $config): void
     {
         $config->defaults([
             'payum.factory_name' => 'be2bill_direct',

diff --git a/Be2BillOffsiteGatewayFactory.php b/Be2BillOffsiteGatewayFactory.php
@@ -10,7 +10,7 @@
 
 class Be2BillOffsiteGatewayFactory extends Be2BillDirectGatewayFactory
 {
-    protected function populateConfig(ArrayObject $config)
+    protected function populateConfig(ArrayObject $config): void
     {
         $config->defaults([
             'payum.factory_name' => 'be2bill_offsite',

diff --git a/Tests/Action/CaptureActionTest.php b/Tests/Action/CaptureActionTest.php
@@ -29,36 +29,36 @@ class CaptureActionTest extends GenericActionTest
 
     protected $requestClass = Capture::class;
 
-    public function testShouldImplementActionInterface()
+    public function testShouldImplementActionInterface(): void
     {
         $rc = new ReflectionClass(CaptureAction::class);
 
         $this->assertTrue($rc->implementsInterface(ActionInterface::class));
     }
 
-    public function testShouldImplementGatewayAwareInterface()
+    public function testShouldImplementGatewayAwareInterface(): void
     {
         $rc = new ReflectionClass(CaptureAction::class);
 
         $this->assertTrue($rc->implementsInterface(GatewayAwareInterface::class));
     }
 
-    public function testShouldImplementApiAwareInterface()
+    public function testShouldImplementApiAwareInterface(): void
     {
         $rc = new ReflectionClass(CaptureAction::class);
 
         $this->assertTrue($rc->implementsInterface(ApiAwareInterface::class));
     }
 
-    public function testThrowIfUnsupportedApiGiven()
+    public function testThrowIfUnsupportedApiGiven(): void
     {
         $this->expectException(UnsupportedApiException::class);
         $action = new CaptureAction();
 
         $action->setApi(new stdClass());
     }
 
-    public function testThrowIfCreditCardNotSetExplicitlyAndObtainRequestNotSupportedOnCapture()
+    public function testThrowIfCreditCardNotSetExplicitlyAndObtainRequestNotSupportedOnCapture(): void
     {
         $this->expectException(LogicException::class);
         $this->expectExceptionMessage('Credit card details has to be set explicitly or there has to be an action that supports ObtainCreditCard request.');
@@ -85,7 +85,7 @@ public function testThrowIfCreditCardNotSetExplicitlyAndObtainRequestNotSupporte
         $action->execute($request);
     }
 
-    public function testShouldDoNothingIfExeccodeSet()
+    public function testShouldDoNothingIfExeccodeSet(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
@@ -110,7 +110,7 @@ public function testShouldDoNothingIfExeccodeSet()
         $action->execute($request);
     }
 
-    public function testShouldCaptureWithCreditCardSetExplicitly()
+    public function testShouldCaptureWithCreditCardSetExplicitly(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
@@ -156,14 +156,14 @@ public function testShouldCaptureWithCreditCardSetExplicitly()
         $this->assertSame('FOOVAL', $model['FOO']);
     }
 
-    public function testShouldCaptureWithObtainedCreditCard()
+    public function testShouldCaptureWithObtainedCreditCard(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(ObtainCreditCard::class))
-            ->willReturnCallback(function (ObtainCreditCard $request) {
+            ->willReturnCallback(function (ObtainCreditCard $request): void {
                 $card = new CreditCard();
                 $card->setNumber('1234567812345678');
                 $card->setExpireAt(new DateTime('2014-10-01'));
@@ -212,14 +212,14 @@ public function testShouldCaptureWithObtainedCreditCard()
         $this->assertNull($model['CARDCODE']->peek(), 'Already erased');
     }
 
-    public function testShouldCaptureWithObtainedCreditCardWhenTokenReturned()
+    public function testShouldCaptureWithObtainedCreditCardWhenTokenReturned(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(ObtainCreditCard::class))
-            ->willReturnCallback(function (ObtainCreditCard $request) {
+            ->willReturnCallback(function (ObtainCreditCard $request): void {
                 $card = new CreditCard();
                 $card->setToken('theCreditCardToken');
 
@@ -264,7 +264,7 @@ public function testShouldCaptureWithObtainedCreditCardWhenTokenReturned()
         ], $model);
     }
 
-    public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubRequest()
+    public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubRequest(): void
     {
         $firstModel = new stdClass();
         $currentModel = new ArrayObject([
@@ -288,7 +288,7 @@ public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubReques
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(ObtainCreditCard::class))
-            ->willReturnCallback(function (ObtainCreditCard $request) use ($firstModel, $currentModel) {
+            ->willReturnCallback(function (ObtainCreditCard $request) use ($firstModel, $currentModel): void {
                 $this->assertSame($firstModel, $request->getFirstModel());
                 $this->assertSame($currentModel, $request->getModel());
 
@@ -309,7 +309,7 @@ public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubReques
         $action->execute($capture);
     }
 
-    public function testShouldThrowHttpResponseIfExecCode3DSecureRequired()
+    public function testShouldThrowHttpResponseIfExecCode3DSecureRequired(): void
     {
         $action = new CaptureAction();
 

diff --git a/Tests/Action/CaptureOffsiteActionTest.php b/Tests/Action/CaptureOffsiteActionTest.php
@@ -23,36 +23,36 @@ class CaptureOffsiteActionTest extends GenericActionTest
 
     protected $requestClass = Capture::class;
 
-    public function testShouldImplementActionInterface()
+    public function testShouldImplementActionInterface(): void
     {
         $rc = new ReflectionClass(CaptureOffsiteAction::class);
 
         $this->assertTrue($rc->implementsInterface(ActionInterface::class));
     }
 
-    public function testShouldImplementGatewayAwareInterface()
+    public function testShouldImplementGatewayAwareInterface(): void
     {
         $rc = new ReflectionClass(CaptureOffsiteAction::class);
 
         $this->assertTrue($rc->implementsInterface(GatewayAwareInterface::class));
     }
 
-    public function testShouldImplementApiAwareInterface()
+    public function testShouldImplementApiAwareInterface(): void
     {
         $rc = new ReflectionClass(CaptureOffsiteAction::class);
 
         $this->assertTrue($rc->implementsInterface(ApiAwareInterface::class));
     }
 
-    public function testThrowIfUnsupportedApiGiven()
+    public function testThrowIfUnsupportedApiGiven(): void
     {
         $this->expectException(UnsupportedApiException::class);
         $action = new CaptureOffsiteAction();
 
         $action->setApi(new stdClass());
     }
 
-    public function testShouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery()
+    public function testShouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery(): void
     {
         $this->expectException(HttpPostRedirect::class);
         $model = [
@@ -91,7 +91,7 @@ public function testShouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery()
         $action->execute($request);
     }
 
-    public function testShouldUpdateModelWhenComeBackFromBe2billSite()
+    public function testShouldUpdateModelWhenComeBackFromBe2billSite(): void
     {
         $model = [
             'AMOUNT' => 1000,
@@ -111,7 +111,7 @@ public function testShouldUpdateModelWhenComeBackFromBe2billSite()
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(GetHttpRequest::class))
-            ->willReturnCallback(function (GetHttpRequest $request) {
+            ->willReturnCallback(function (GetHttpRequest $request): void {
                 $request->query['EXECCODE'] = 1;
                 $request->query['FOO'] = 'fooVal';
             })

diff --git a/Tests/Action/ConvertPaymentActionTest.php b/Tests/Action/ConvertPaymentActionTest.php
@@ -36,7 +36,7 @@ public function provideNotSupportedRequests(): Iterator
         yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'foobar')];
     }
 
-    public function testShouldCorrectlyConvertOrderToDetailsAndSetItBack()
+    public function testShouldCorrectlyConvertOrderToDetailsAndSetItBack(): void
     {
         $payment = new Payment();
         $payment->setNumber('theNumber');
@@ -70,7 +70,7 @@ public function testShouldCorrectlyConvertOrderToDetailsAndSetItBack()
         $this->assertSame('theClientEmail', $details['CLIENTEMAIL']);
     }
 
-    public function testShouldNotOverwriteAlreadySetExtraDetails()
+    public function testShouldNotOverwriteAlreadySetExtraDetails(): void
     {
         $payment = new Payment();
         $payment->setCurrencyCode('USD');

diff --git a/Tests/Action/NotifyActionTest.php b/Tests/Action/NotifyActionTest.php
@@ -23,36 +23,36 @@ class NotifyActionTest extends GenericActionTest
 
     protected $requestClass = Notify::class;
 
-    public function testShouldImplementGatewayAwareInterface()
+    public function testShouldImplementGatewayAwareInterface(): void
     {
         $rc = new ReflectionClass(NotifyAction::class);
 
         $this->assertTrue($rc->implementsInterface(GatewayAwareInterface::class));
     }
 
-    public function testShouldImplementApiAwareInterface()
+    public function testShouldImplementApiAwareInterface(): void
     {
         $rc = new ReflectionClass(NotifyAction::class);
 
         $this->assertTrue($rc->implementsInterface(ApiAwareInterface::class));
     }
 
-    public function testThrowIfUnsupportedApiGiven()
+    public function testThrowIfUnsupportedApiGiven(): void
     {
         $this->expectException(UnsupportedApiException::class);
         $action = new NotifyAction();
 
         $action->setApi(new stdClass());
     }
 
-    public function testThrowIfQueryHashDoesNotMatchExpected()
+    public function testThrowIfQueryHashDoesNotMatchExpected(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(GetHttpRequest::class))
-            ->willReturnCallback(function (GetHttpRequest $request) {
+            ->willReturnCallback(function (GetHttpRequest $request): void {
                 $request->query = ['expected be2bill query'];
             })
         ;
@@ -80,14 +80,14 @@ public function testThrowIfQueryHashDoesNotMatchExpected()
         $this->fail('The exception is expected');
     }
 
-    public function testThrowIfQueryAmountDoesNotMatchOneFromModel()
+    public function testThrowIfQueryAmountDoesNotMatchOneFromModel(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(GetHttpRequest::class))
-            ->willReturnCallback(function (GetHttpRequest $request) {
+            ->willReturnCallback(function (GetHttpRequest $request): void {
                 $request->query = [
                     'AMOUNT' => 2.0,
                 ];
@@ -119,14 +119,14 @@ public function testThrowIfQueryAmountDoesNotMatchOneFromModel()
         $this->fail('The exception is expected');
     }
 
-    public function testShouldUpdateModelIfNotificationValid()
+    public function testShouldUpdateModelIfNotificationValid(): void
     {
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
             ->with($this->isInstanceOf(GetHttpRequest::class))
-            ->willReturnCallback(function (GetHttpRequest $request) {
+            ->willReturnCallback(function (GetHttpRequest $request): void {
                 $request->query = [
                     'AMOUNT' => 1.0,
                     'FOO' => 'FOO',