Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed interaction between block replacement effect from Determined Survivor and Necromantic Aegis #8417

Conversation

Jonathan-Dang
Copy link
Contributor

Fixes interaction between Block Replacement effect granted from Gladiator's "Determined Survivor" ascendency with Necromantic Aegis.
Now grants minion base 50% block chance given from Determined Survivor and Ascendant's Gladiator Ascendency.

Fixes #8358 .

Description of the problem being solved:

While allocating Determined Survivor or Gladiator Ascendancy, it did not grant minions the replaced 50% block chance when Necromantic Aegis is allocated.

Steps taken to verify a working solution:

  • Create both Duelist and Scion with said ascendancies allocated and have any base block shield equiped.
  • Set active skill to Summon Zombie or any summon, set calc mode to view minion
  • See if active block chance is 50% rather than base shield block chance.

Link to a build that showcases this PR:

Duelist: https://pobb.in/PweoXCGVDI6_
Scion: https://pobb.in/5apC4rtoIUyg

No Screenshots required for this change.

…th Necromantic Aegis

Fixes interaction between Block Replacement effect granted from Gladiator's "Determined Survivor" ascendency with Necromantic Aegis.
src/Modules/CalcDefence.lua Outdated Show resolved Hide resolved
@Paliak Paliak added the bug: behaviour Behavioral differences label Jan 19, 2025
Jonathan-Dang and others added 3 commits January 19, 2025 15:27
Needs to be baseBlockChance or else it doesn't have the complete 50% block chance granted from Ascendency.
Comment on lines 524 to 528
baseBlockChance = modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance

-- Apply player block overrides if Necromantic Aegis allocated
baseBlockChance = actor == env.minion and env.keystonesAdded["Necromantic Aegis"] and env.player.modDB:Override(nil, "ReplaceShieldBlock") or output.ShieldBlockChance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't see that it was used below. This should be correct now.

Suggested change
baseBlockChance = modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance
-- Apply player block overrides if Necromantic Aegis allocated
baseBlockChance = actor == env.minion and env.keystonesAdded["Necromantic Aegis"] and env.player.modDB:Override(nil, "ReplaceShieldBlock") or output.ShieldBlockChance
output.ShieldBlockChance = baseBlockChance
baseBlockChance = modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance
-- Apply player block overrides if Necromantic Aegis allocated
baseBlockChance = actor == env.minion and env.keystonesAdded["Necromantic Aegis"] and env.player.modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance

@LocalIdentity LocalIdentity merged commit 4f25340 into PathOfBuildingCommunity:dev Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
3 participants