-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed interaction between block replacement effect from Determined Survivor and Necromantic Aegis #8417
Merged
LocalIdentity
merged 6 commits into
PathOfBuildingCommunity:dev
from
Jonathan-Dang:Gladiator-Necromantic-Aegis-8358
Feb 12, 2025
Merged
Fixed interaction between block replacement effect from Determined Survivor and Necromantic Aegis #8417
LocalIdentity
merged 6 commits into
PathOfBuildingCommunity:dev
from
Jonathan-Dang:Gladiator-Necromantic-Aegis-8358
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th Necromantic Aegis Fixes interaction between Block Replacement effect granted from Gladiator's "Determined Survivor" ascendency with Necromantic Aegis.
Paliak
reviewed
Jan 19, 2025
Co-authored-by: Paliak <[email protected]>
Needs to be baseBlockChance or else it doesn't have the complete 50% block chance granted from Ascendency.
Paliak
reviewed
Jan 19, 2025
src/Modules/CalcDefence.lua
Outdated
Comment on lines
524
to
528
baseBlockChance = modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance | ||
|
||
-- Apply player block overrides if Necromantic Aegis allocated | ||
baseBlockChance = actor == env.minion and env.keystonesAdded["Necromantic Aegis"] and env.player.modDB:Override(nil, "ReplaceShieldBlock") or output.ShieldBlockChance | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't see that it was used below. This should be correct now.
Suggested change
baseBlockChance = modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance | |
-- Apply player block overrides if Necromantic Aegis allocated | |
baseBlockChance = actor == env.minion and env.keystonesAdded["Necromantic Aegis"] and env.player.modDB:Override(nil, "ReplaceShieldBlock") or output.ShieldBlockChance | |
output.ShieldBlockChance = baseBlockChance | |
baseBlockChance = modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance | |
-- Apply player block overrides if Necromantic Aegis allocated | |
baseBlockChance = actor == env.minion and env.keystonesAdded["Necromantic Aegis"] and env.player.modDB:Override(nil, "ReplaceShieldBlock") or baseBlockChance | |
LocalIdentity
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes interaction between Block Replacement effect granted from Gladiator's "Determined Survivor" ascendency with Necromantic Aegis.
Now grants minion base 50% block chance given from Determined Survivor and Ascendant's Gladiator Ascendency.
Fixes #8358 .
Description of the problem being solved:
While allocating Determined Survivor or Gladiator Ascendancy, it did not grant minions the replaced 50% block chance when Necromantic Aegis is allocated.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Duelist: https://pobb.in/PweoXCGVDI6_
Scion: https://pobb.in/5apC4rtoIUyg
No Screenshots required for this change.