Use ruff for linting and formatting #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 25, 2024 16:58
… in pre-commit configuration
added 5 commits
November 25, 2024 17:24
bthirion
reviewed
Nov 27, 2024
emdupre
reviewed
Nov 28, 2024
examples/plot_toy_int_experiment.py
Outdated
| tuning_pred_run_1, | ||
| tuning_pred_run_2, | ||
| n_components=2, | ||
| dissimilarity=1 - corr_tunning, |
There was a problem hiding this comment.
Will ruff complain if this is formatted as
Suggested change
| dissimilarity=1 - corr_tunning, | |
| dissimilarity=(1 - corr_tunning), |
? I find it more human-readable, but not worth breaking automation !
There was a problem hiding this comment.
Both ruff format and ruff check don't seem to complain so I'm adding it.
emdupre
approved these changes
Nov 28, 2024
I'm merging it as soon as CI finishes. |
|
There are still a lot of issues regarding docstrings and documentation though, I suggest adding D-related rules in a future PR. |
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104. Adds ruff to replace flake8, isort and black.
Follows the same config as
nilearnfor consistency.