Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old upgrade payment logic #10860

Merged
merged 10 commits into from
Feb 24, 2025

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Feb 12, 2025

Fix #9887

This includes removing the conversion modal, discussed in Slack here 🔒 : https://parabol.slack.com/archives/C029ZTH0EL9/p1739289011187399

To test

  • Upgrade from to Team plan and see that everything continues to work. You'll need to add stripe listen --forward-to localhost:3000/stripe to a terminal to be able to upgrade.

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@nickoferrall nickoferrall marked this pull request as ready for review February 18, 2025 16:30
@Dschoordsch
Copy link
Contributor

You are removing the conversion modal. I don't see that mentioned in the issue or the PR. Was this discussed with sales?

@nickoferrall
Copy link
Contributor Author

Yep, that was discussed here: https://parabol.slack.com/archives/C029ZTH0EL9/p1739289011187399

I should have included it in the PR description. I'll add it there now.

import type {Kysely} from 'kysely'

export async function up(db: Kysely<any>): Promise<void> {
await db.schema.alterTable('NewMeeting').dropColumn('showConversionModal').execute()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 let's remove the payLaterClickCount fields from User and Organization as well, because it isn't updated anywhere anymore

Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@nickoferrall nickoferrall merged commit c86b5cc into master Feb 24, 2025
7 checks passed
@nickoferrall nickoferrall deleted the chore/9887/remove-old-upgrade branch February 24, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old upgrade logic
2 participants