Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module/subnet_set): ma_public_ip_on_launch per subnet #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lstadnik
Copy link
Contributor

Description

Ability to specify public IP auto-assignment at subnet-level

Motivation and Context

Although we don't recommend auto-assigned Public IP for production deployment. The EIP was already addressed for our modules the new functionality was added to comply with other non-production scenarios.

How Has This Been Tested?

chatbot should verify scenarios

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@lstadnik lstadnik requested a review from a team as a code owner February 10, 2025 14:46
@lstadnik lstadnik linked an issue Feb 10, 2025 that may be closed by this pull request
@lstadnik
Copy link
Contributor Author

lstadnik commented Feb 10, 2025

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale"

Testing job ID: 13243578967
Job result: FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Auto-assign public IP in VPC config
2 participants