Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] update sequence parallel #9757

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

DesmonDay
Copy link
Contributor

@DesmonDay DesmonDay commented Jan 8, 2025

PR types

Function optimization

PR changes

Others

Description

When use pipeline parallel and sequence parallel simultaneously, we should turn off partial send recv.

Copy link

paddle-bot bot commented Jan 8, 2025

Thanks for your contribution!

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (fb60645) to head (f8b1800).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/training_args.py 33.33% 4 Missing ⚠️
paddlenlp/trainer/trainer.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9757      +/-   ##
===========================================
- Coverage    52.70%   52.37%   -0.33%     
===========================================
  Files          731      727       -4     
  Lines       117313   115155    -2158     
===========================================
- Hits         61827    60310    -1517     
+ Misses       55486    54845     -641     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay DesmonDay force-pushed the fix_seq branch 2 times, most recently from 1a21cd5 to 934a757 Compare January 9, 2025 03:44
ZHUI
ZHUI previously approved these changes Jan 9, 2025
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay DesmonDay changed the title [Trainer] fix sequence parallel [Trainer] update sequence parallel Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants