Correct pluralization of the word space/spaces depending on the spacing value

[DannyvdSluijs]

This PR fixes more occurences of the word space(s) to be either space or spaces depending on the spacing value.

Description

This PR is a port of squizlabs/PHP_CodeSniffer#3881 to this repo which was created after some brief discussion with @jrfnl in squizlabs/PHP_CodeSniffer#3647 and addressing the Sniff I've pointed out in squizlabs/PHP_CodeSniffer#3647 (review)

Suggested changelog entry

Correct pluralization of the word space/spaces depending on the spacing value

Related issues/external references

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.

[jrfnl]

@DannyvdSluijs Could you please rebase your PR ? Status checks are required now and as some things have changed in the workflows we won't be able to get a passing build without a rebase.

[jrfnl]

Thanks @DannyvdSluijs for porting this over. I review the changes again and will merge the PR now, including some additional changes.

Review notes:

• Generic.Arrays.ArrayIndent
  • Has new tests covering 1/more than 1 spaces for KeyIncorrect and CloseBraceIncorrect error codes ✅
  • Missing test for OpenBraceIncorrect error code ❌
  • Missing tests with $indent set to 0 spaces. This is not necessarily a biggie for this PR, but something which should have been included in the tests for this sniff anyhow, so now is as good a time as any to fix this up ❌
  • Code review ✅
• Generic.Formatting.SpaceAfterCast
  • Has (pre-existing) tests covering 0/1/more than 1 spaces for all affected error codes ✅
  • Code review ✅
• Generic.Formatting.SpaceAfterNot
  • Has (pre-existing) tests covering 0/1/more than 1 spaces for all affected error codes ✅
  • Code review ✅
• Squiz.Arrays.ArrayDeclaration
  • Has (partially new, partially pre-existing) tests 1/more than 1 spaces ✅
    No test with 0 spaces for most error codes, but that's okay as "spaces" is not configurable.
  • Code review ✅
• Squiz.Commenting.DocCommentAlignment
  • Has (pre-existing) tests covering 1/more than 1 spaces ✅
    No test with 0 spaces, but that's okay as "spaces" is not configurable.
  • Code review ✅
• Squiz.ControlStructures.ControlSignature
  • Has (pre-existing) tests covering the 0/1 spaces ✅
  • Missing test where (configurable) requiredSpacesBeforeColon property is set to > 1. ❌
  • Code review ✅

As I said I'd include this PR in the 3.8.0 release, I've taken the liberty to fix the missing tests up myself (which I normally wouldn't).

For future reference: I'd rather receive multiple PRs with each PR only addressing one sniff, as it makes reviewing easier and one change not being ready doesn't have to block other changes.