Merge pull request #335 from FatchipRobert/MAG2-165-TransactionParam

MAG2-165 TransactionParam

Model/Api/Request/Authorization.php

@@ -187,6 +187,9 @@ protected function setPaymentParameters(PayoneMethod $oPayment, Order $oOrder)
         $sNarrativeText = $this->toolkitHelper->getNarrativeText($oOrder, $oPayment);
         if (!empty($sNarrativeText)) {// narrative text existing?
             $this->addParameter('narrative_text', $sNarrativeText); // add narrative text parameter
+            if ($oPayment->needsTransactionParam() === true) {
+                $this->addParameter('transaction_param', preg_replace('/[^0-9A-Z._\/\-]/i', "", $sNarrativeText));
+            }
         }
         $aPaymentParams = $oPayment->getPaymentSpecificParameters($oOrder); // get payment params specific to the payment type
         $this->aParameters = array_merge($this->aParameters, $aPaymentParams); // merge payment params with other params

Model/Methods/BaseMethod.php

@@ -114,6 +114,13 @@ abstract class BaseMethod extends AbstractMethod
      */
     protected $blNeedsRedirectUrls = false;
 
+    /**
+     * Determines if the transaction_param-parameter has to be added to the authorization-request
+     *
+     * @var bool
+     */
+    protected $blNeedsTransactionParam = false;
+
     /**
      * Determines if the invoice information has to be added
      * to the authorization-request

Model/Methods/PayoneMethod.php

@@ -275,6 +275,16 @@ public function needsRedirectUrls()
         return $this->blNeedsRedirectUrls;
     }
 
+    /**
+     * Return if transaction_param has to be added to the authroization request
+     *
+     * @return bool
+     */
+    public function needsTransactionParam()
+    {
+        return $this->blNeedsTransactionParam;
+    }
+
     /**
      * Return if invoice data has to be added to the authroization request
      *

Model/Methods/Paypal.php

@@ -56,6 +56,13 @@ class Paypal extends PayoneMethod
      */
     protected $blNeedsRedirectUrls = true;
 
+    /**
+     * Determines if the transaction_param-parameter has to be added to the authorization-request
+     *
+     * @var bool
+     */
+    protected $blNeedsTransactionParam = true;
+
     /**
      * Return success url for redirect payment types
      *

Test/Unit/Model/Api/Request/AuthorizationTest.php

@@ -124,6 +124,7 @@ private function getPaymentMock()
         $payment->method('getClearingtype')->willReturn('wlt');
         $payment->method('getPaymentSpecificParameters')->willReturn([]);
         $payment->method('needsRedirectUrls')->willReturn(true);
+        $payment->method('needsTransactionParam')->willReturn(true);
         $payment->method('getSuccessUrl')->willReturn('http://testdomain.com');
         $payment->method('getErrorUrl')->willReturn('http://testdomain.com');
         $payment->method('getCancelUrl')->willReturn('http://testdomain.com');

Test/Unit/Model/Methods/PayoneMethodTest.php

@@ -103,6 +103,12 @@ public function testNeedsRedirectUrls()
         $this->assertTrue($result);
     }
 
+    public function testNeedsTransactionParam()
+    {
+        $result = $this->classToTest->needsTransactionParam();
+        $this->assertFalse($result);
+    }
+
     public function testNeedsProductInfo()
     {
         $result = $this->classToTest->needsProductInfo();